Re: [PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

2018-11-14 Thread Alexandre Belloni
On 14/11/2018 17:50:25+0100, Christophe JAILLET wrote: > In case of error, we return 0. > This is spurious and not consistent with the other functions of the driver. > Commit 22652ba72453 has modified more than what is said in the commit > message and error should be propagated. > > Fixes:

Re: [PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

2018-11-14 Thread Alexandre Belloni
On 14/11/2018 17:50:25+0100, Christophe JAILLET wrote: > In case of error, we return 0. > This is spurious and not consistent with the other functions of the driver. > Commit 22652ba72453 has modified more than what is said in the commit > message and error should be propagated. > > Fixes:

[PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

2018-11-14 Thread Christophe JAILLET
In case of error, we return 0. This is spurious and not consistent with the other functions of the driver. Commit 22652ba72453 has modified more than what is said in the commit message and error should be propagated. Fixes: 22652ba72453 ("rtc: stop validating rtc_time in .read_time")

[PATCH] rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'

2018-11-14 Thread Christophe JAILLET
In case of error, we return 0. This is spurious and not consistent with the other functions of the driver. Commit 22652ba72453 has modified more than what is said in the commit message and error should be propagated. Fixes: 22652ba72453 ("rtc: stop validating rtc_time in .read_time")