Re: [PATCH] rtw88: 8821c: Add RFE 2 support
On Tue, Feb 2, 2021 at 3:02 PM Larry Finger wrote: > > On 2/2/21 12:29 AM, Kalle Valo wrote: > > Kai-Heng Feng writes: > > > >> On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng > >> wrote: > >>> > >>> Hi Tony, > >>> > On Aug 5, 2020, at 19:18, Tony Chuang wrote: > > > 8821CE with RFE 2 isn't supported: > > [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported > > [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info > > [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information > > > > NACK > > The RFE type 2 should be working with some additional fixes. > Did you tested connecting to AP with BT paired? > >>> > >>> No, I only tested WiFi. > >>> > The antenna configuration is different with RFE type 0. > I will ask someone else to fix them. > Then the RFE type 2 modules can be supported. > >>> > >>> Good to know that, I'll be patient and wait for a real fix. > >> > >> It's been quite some time, is support for RFE type 2 ready now? > > > > It looks like this patch should add it: > > > > https://patchwork.kernel.org/project/linux-wireless/patch/20210202055012.8296-4-pks...@realtek.com/ > > > New firmware (rtw8821c_fw.bin) is also needed. That is available at > https://github.com/lwfinger/rtw88.git. Thanks. RFE2 works with the new firmware. Kai-Heng > > Larry >
Re: [PATCH] rtw88: 8821c: Add RFE 2 support
On 2/2/21 12:29 AM, Kalle Valo wrote: Kai-Heng Feng writes: On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng wrote: Hi Tony, On Aug 5, 2020, at 19:18, Tony Chuang wrote: 8821CE with RFE 2 isn't supported: [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information NACK The RFE type 2 should be working with some additional fixes. Did you tested connecting to AP with BT paired? No, I only tested WiFi. The antenna configuration is different with RFE type 0. I will ask someone else to fix them. Then the RFE type 2 modules can be supported. Good to know that, I'll be patient and wait for a real fix. It's been quite some time, is support for RFE type 2 ready now? It looks like this patch should add it: https://patchwork.kernel.org/project/linux-wireless/patch/20210202055012.8296-4-pks...@realtek.com/ New firmware (rtw8821c_fw.bin) is also needed. That is available at https://github.com/lwfinger/rtw88.git. Larry
Re: [PATCH] rtw88: 8821c: Add RFE 2 support
Kai-Heng Feng writes: > On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng > wrote: >> >> Hi Tony, >> >> > On Aug 5, 2020, at 19:18, Tony Chuang wrote: >> > >> >> 8821CE with RFE 2 isn't supported: >> >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported >> >> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info >> >> [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information >> >> >> > >> > NACK >> > >> > The RFE type 2 should be working with some additional fixes. >> > Did you tested connecting to AP with BT paired? >> >> No, I only tested WiFi. >> >> > The antenna configuration is different with RFE type 0. >> > I will ask someone else to fix them. >> > Then the RFE type 2 modules can be supported. >> >> Good to know that, I'll be patient and wait for a real fix. > > It's been quite some time, is support for RFE type 2 ready now? It looks like this patch should add it: https://patchwork.kernel.org/project/linux-wireless/patch/20210202055012.8296-4-pks...@realtek.com/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH] rtw88: 8821c: Add RFE 2 support
On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng wrote: > > Hi Tony, > > > On Aug 5, 2020, at 19:18, Tony Chuang wrote: > > > >> 8821CE with RFE 2 isn't supported: > >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported > >> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info > >> [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information > >> > > > > NACK > > > > The RFE type 2 should be working with some additional fixes. > > Did you tested connecting to AP with BT paired? > > No, I only tested WiFi. > > > The antenna configuration is different with RFE type 0. > > I will ask someone else to fix them. > > Then the RFE type 2 modules can be supported. > > Good to know that, I'll be patient and wait for a real fix. It's been quite some time, is support for RFE type 2 ready now? Kai-Heng > > Kai-Heng > > > > > Yen-Hsuan >
RE: [PATCH] rtw88: 8821c: Add RFE 2 support
> 8821CE with RFE 2 isn't supported: > [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported > [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info > [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information > NACK The RFE type 2 should be working with some additional fixes. Did you tested connecting to AP with BT paired? The antenna configuration is different with RFE type 0. I will ask someone else to fix them. Then the RFE type 2 modules can be supported. Yen-Hsuan
Re: [PATCH] rtw88: 8821c: Add RFE 2 support
Hi Tony, > On Aug 5, 2020, at 19:18, Tony Chuang wrote: > >> 8821CE with RFE 2 isn't supported: >> [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported >> [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info >> [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information >> > > NACK > > The RFE type 2 should be working with some additional fixes. > Did you tested connecting to AP with BT paired? No, I only tested WiFi. > The antenna configuration is different with RFE type 0. > I will ask someone else to fix them. > Then the RFE type 2 modules can be supported. Good to know that, I'll be patient and wait for a real fix. Kai-Heng > > Yen-Hsuan
[PATCH] rtw88: 8821c: Add RFE 2 support
8821CE with RFE 2 isn't supported:
[ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported
[ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info
[ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information
It works well if both type0 tables are in use, so add it to the RFE
default.
Signed-off-by: Kai-Heng Feng
---
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index d8863d8a5468..f7270d0f1d55 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -1410,6 +1410,7 @@ static const struct rtw_intf_phy_para_table
phy_para_table_8821c = {
static const struct rtw_rfe_def rtw8821c_rfe_defs[] = {
[0] = RTW_DEF_RFE(8821c, 0, 0),
+ [2] = RTW_DEF_RFE(8821c, 0, 0),
};
static struct rtw_hw_reg rtw8821c_dig[] = {
--
2.17.1
