Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver

2020-09-15 Thread Harald Freudenberger
:00:00 2001 From: Harald Freudenberger Date: Thu, 10 Sep 2020 11:32:43 +0200 Subject: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device  driver This patch reworks the zcrypt device driver so that the set_fs() invocation is not needed any more. Instead there is a new flag bool usersp

Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver

2020-09-15 Thread Christoph Hellwig
On Mon, Sep 14, 2020 at 09:36:07AM +0200, Harald Freudenberger wrote: > Christoph, maybe you have a greater idea on how to solve this. So don't > hesitate and tell me. > Otherwise how to we provide this fix then ? My recommendation would be to go > the 'usual' way: > Commit this s390 internal

Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver

2020-09-14 Thread Heiko Carstens
On Mon, Sep 14, 2020 at 09:36:07AM +0200, Harald Freudenberger wrote: > Otherwise how to we provide this fix then ? My recommendation would > be to go the 'usual' way: Commit this s390 internal and then let > this go out with the next kernel merge window when next time Linus > is pulling patches

Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver

2020-09-14 Thread Harald Freudenberger
On 11.09.20 08:21, Christoph Hellwig wrote: > On Thu, Sep 10, 2020 at 12:28:38PM +0200, Harald Freudenberger wrote: >> +static inline unsigned long z_copy_from_user(bool userspace, >> + void *to, const void __user *from, >> unsigned long n) > Can you avoid

Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver

2020-09-11 Thread Christoph Hellwig
On Thu, Sep 10, 2020 at 12:28:38PM +0200, Harald Freudenberger wrote: > +static inline unsigned long z_copy_from_user(bool userspace, > + void *to, const void __user *from, > unsigned long n) Can you avoid the pointless long lines in the function

[PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver

2020-09-10 Thread Harald Freudenberger
This patch reworks the zcrypt device driver so that the set_fs() invocation is not needed any more. Instead there is a new flag bool userspace passed through all the functions which tells if the pointer arguments are userspace or kernelspace. Together with the two new inline functions