Re: [PATCH] s390: add unreachable() to dump_fault_info() to fix -Wmaybe-uninitialized

2019-05-17 Thread Martin Schwidefsky
On Fri, 17 May 2019 15:49:22 +0900 Masahiro Yamada wrote: > When CONFIG_OPTIMIZE_INLINING is enabled for s390, I see this warning: > > arch/s390/mm/fault.c:127:15: warning: 'asce' may be used uninitialized in > this function [-Wmaybe-uninitialized] > switch (asce & _ASCE_TYPE_MASK) { >

Re: [PATCH] s390: add unreachable() to dump_fault_info() to fix -Wmaybe-uninitialized

2019-05-17 Thread Sergey Senozhatsky
On (05/17/19 15:49), Masahiro Yamada wrote: [..] > @@ -211,6 +211,8 @@ static void dump_fault_info(struct pt_regs *regs) > asce = S390_lowcore.kernel_asce; > pr_cont("kernel "); > break; > + default: > + unreachable(); > } >

[PATCH] s390: add unreachable() to dump_fault_info() to fix -Wmaybe-uninitialized

2019-05-17 Thread Masahiro Yamada
When CONFIG_OPTIMIZE_INLINING is enabled for s390, I see this warning: arch/s390/mm/fault.c:127:15: warning: 'asce' may be used uninitialized in this function [-Wmaybe-uninitialized] switch (asce & _ASCE_TYPE_MASK) { arch/s390/mm/fault.c:177:16: note: 'asce' was declared here unsigned long