Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Joe Perches
On Tue, 2015-04-07 at 14:47 +0100, Juri Lelli wrote: how about we add also something like this to checkpatch? [] Production kernels will scream if trace_printk() is used (thanks to Rostedt's banner). Rather than waiting for that to happen, let's check patches beforehand. [] diff --git

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 07:26:13 -0700 Joe Perches j...@perches.com wrote: On Tue, 2015-04-07 at 10:10 -0400, Steven Rostedt wrote: On Tue, 07 Apr 2015 07:01:37 -0700 Joe Perches j...@perches.com wrote: o Please add a test for $realfile !~ m@kernel/trace/@ or maybe $realfile !~

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Juri Lelli
On 03/04/2015 09:42, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Commit 3c18d447b3b3 (sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()) forgot a trace_printk debugging piece in and Steve's banner blew in dmesg. Remove it. Argh! Sorry about that!

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Joe Perches
On Tue, 2015-04-07 at 10:10 -0400, Steven Rostedt wrote: On Tue, 07 Apr 2015 07:01:37 -0700 Joe Perches j...@perches.com wrote: o Please add a test for $realfile !~ m@kernel/trace/@ or maybe $realfile !~ /(?:trace|tracing)/ o ERROR seems a bit strong, WARN is probably good enough

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 14:47:50 +0100 Juri Lelli juri.le...@arm.com wrote: On 03/04/2015 09:42, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Commit 3c18d447b3b3 (sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()) forgot a trace_printk debugging

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Juri Lelli
On 07/04/15 14:56, Steven Rostedt wrote: On Tue, 07 Apr 2015 14:47:50 +0100 Juri Lelli juri.le...@arm.com wrote: On 03/04/2015 09:42, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Commit 3c18d447b3b3 (sched/core: Check for available DL bandwidth in cpuset_cpu_inactive())

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Joe Perches
On Tue, 2015-04-07 at 10:34 -0400, Steven Rostedt wrote: On Tue, 07 Apr 2015 07:26:13 -0700 Joe Perches j...@perches.com wrote: On Tue, 2015-04-07 at 10:10 -0400, Steven Rostedt wrote: On Tue, 07 Apr 2015 07:01:37 -0700 Joe Perches j...@perches.com wrote: o ERROR seems a bit strong, WARN

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Steven Rostedt
On Tue, 07 Apr 2015 07:01:37 -0700 Joe Perches j...@perches.com wrote: o Please add a test for $realfile !~ m@kernel/trace/@ or maybe $realfile !~ /(?:trace|tracing)/ o ERROR seems a bit strong, WARN is probably good enough I'm thinking ERROR is good. There's no reason to have it. In fact,

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-07 Thread Peter Zijlstra
On Tue, Apr 07, 2015 at 10:34:04AM -0400, Steven Rostedt wrote: I still rather have this be an ERROR and not a WARN, because I rather avoid even those that encapsulate it with CONFIG_FOO_DEBUG. Lets look at it this way; Steve maintains that trace_printk() thing, if he says its an ERROR, it is.

[PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-03 Thread Borislav Petkov
From: Borislav Petkov b...@suse.de Commit 3c18d447b3b3 (sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()) forgot a trace_printk debugging piece in and Steve's banner blew in dmesg. Remove it. Signed-off-by: Borislav Petkov b...@suse.de Cc: Juri Lelli juri.le...@arm.com

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-03 Thread Steven Rostedt
On Fri, 3 Apr 2015 10:42:50 +0200 Borislav Petkov b...@alien8.de wrote: From: Borislav Petkov b...@suse.de Commit 3c18d447b3b3 (sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()) forgot a trace_printk debugging piece in and Steve's banner blew in dmesg. Remove

Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

2015-04-03 Thread Borislav Petkov
On Fri, Apr 03, 2015 at 09:24:01AM -0400, Steven Rostedt wrote: On Fri, 3 Apr 2015 10:42:50 +0200 Borislav Petkov b...@alien8.de wrote: From: Borislav Petkov b...@suse.de Commit 3c18d447b3b3 (sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()) forgot a