Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On 27/06/16 17:52, Peter Zijlstra wrote: > On Fri, Jun 17, 2016 at 05:28:37PM +0100, Juri Lelli wrote: > > On 17/06/16 09:49, Steven Rostedt wrote: > > > On Fri, 17 Jun 2016 10:48:41 +0100 > > > Juri Lelli wrote: > > > > > > > setup_new_dl_entity() takes two parameters, but

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On 27/06/16 17:52, Peter Zijlstra wrote: > On Fri, Jun 17, 2016 at 05:28:37PM +0100, Juri Lelli wrote: > > On 17/06/16 09:49, Steven Rostedt wrote: > > > On Fri, 17 Jun 2016 10:48:41 +0100 > > > Juri Lelli wrote: > > > > > > > setup_new_dl_entity() takes two parameters, but it only actually uses

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, Jun 17, 2016 at 05:28:37PM +0100, Juri Lelli wrote: > On 17/06/16 09:49, Steven Rostedt wrote: > > On Fri, 17 Jun 2016 10:48:41 +0100 > > Juri Lelli wrote: > > > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > > one of them to setup a new

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, Jun 17, 2016 at 05:28:37PM +0100, Juri Lelli wrote: > On 17/06/16 09:49, Steven Rostedt wrote: > > On Fri, 17 Jun 2016 10:48:41 +0100 > > Juri Lelli wrote: > > > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > > one of them to setup a new dl_entity. > > > >

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, 17 Jun 2016 22:15:18 +0200 luca abeni wrote: > On Fri, 17 Jun 2016 17:28:37 +0100 > Juri Lelli wrote: > [...] > > True, but we were practically already using the same parameter, under a > > different name though, after > > > > 2f9f3fdc928

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, 17 Jun 2016 22:15:18 +0200 luca abeni wrote: > On Fri, 17 Jun 2016 17:28:37 +0100 > Juri Lelli wrote: > [...] > > True, but we were practically already using the same parameter, under a > > different name though, after > > > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, 17 Jun 2016 17:28:37 +0100 Juri Lelli wrote: [...] > True, but we were practically already using the same parameter, under a > different name though, after > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > as we currently do: > >

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, 17 Jun 2016 17:28:37 +0100 Juri Lelli wrote: [...] > True, but we were practically already using the same parameter, under a > different name though, after > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > as we currently do: > > setup_new_dl_entity(>dl,

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On 17/06/16 09:49, Steven Rostedt wrote: > On Fri, 17 Jun 2016 10:48:41 +0100 > Juri Lelli wrote: > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them to setup a new dl_entity. > > > > Actually this patch is making it so that

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On 17/06/16 09:49, Steven Rostedt wrote: > On Fri, 17 Jun 2016 10:48:41 +0100 > Juri Lelli wrote: > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them to setup a new dl_entity. > > > > Actually this patch is making it so that setup_new_dl_entity() only >

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, 17 Jun 2016 10:48:41 +0100 Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them to setup a new dl_entity. > Actually this patch is making it so that setup_new_dl_entity() only uses one of the parameters. Can you

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On Fri, 17 Jun 2016 10:48:41 +0100 Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them to setup a new dl_entity. > Actually this patch is making it so that setup_new_dl_entity() only uses one of the parameters. Can you note why that change

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On 17/06/16 11:58, Luca Abeni wrote: > Hi, > > On Fri, 17 Jun 2016 10:48:41 +0100 > Juri Lelli wrote: > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them to setup a new dl_entity. > > > > Remove the second, useless, parameter. > >

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

On 17/06/16 11:58, Luca Abeni wrote: > Hi, > > On Fri, 17 Jun 2016 10:48:41 +0100 > Juri Lelli wrote: > > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them to setup a new dl_entity. > > > > Remove the second, useless, parameter. > > Funnily enough, I was

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

Hi, On Fri, 17 Jun 2016 10:48:41 +0100 Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them to setup a new dl_entity. > > Remove the second, useless, parameter. Funnily enough, I was adding something similar in my local

Re: [PATCH] sched/deadline: remove useless param from setup_new_dl_entity

Hi, On Fri, 17 Jun 2016 10:48:41 +0100 Juri Lelli wrote: > setup_new_dl_entity() takes two parameters, but it only actually uses > one of them to setup a new dl_entity. > > Remove the second, useless, parameter. Funnily enough, I was adding something similar in my local queue :) Looks good to

[PATCH] sched/deadline: remove useless param from setup_new_dl_entity

setup_new_dl_entity() takes two parameters, but it only actually uses one of them to setup a new dl_entity. Remove the second, useless, parameter. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Luca Abeni

[PATCH] sched/deadline: remove useless param from setup_new_dl_entity

setup_new_dl_entity() takes two parameters, but it only actually uses one of them to setup a new dl_entity. Remove the second, useless, parameter. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Luca Abeni Signed-off-by: Juri Lelli --- kernel/sched/deadline.c | 9 - 1