Re: [PATCH] sched/fair: move capacity_margin definition into #ifdef

2018-12-11 Thread Olof Johansson
On Mon, Dec 10, 2018 at 11:46 PM Vincent Guittot wrote: > > Hi Arnd, > > On Mon, 10 Dec 2018 at 22:01, Arnd Bergmann wrote: > > > > Marking the variable static showed that it's only used for > > SMP builds, as seen from this warning: > > > > kernel/sched/fair.c:119:21: error: 'capacity_margin'

Re: [PATCH] sched/fair: move capacity_margin definition into #ifdef

2018-12-10 Thread Vincent Guittot
Hi Arnd, On Mon, 10 Dec 2018 at 22:01, Arnd Bergmann wrote: > > Marking the variable static showed that it's only used for > SMP builds, as seen from this warning: > > kernel/sched/fair.c:119:21: error: 'capacity_margin' defined but not used > [-Werror=unused-variable] > static unsigned int

[PATCH] sched/fair: move capacity_margin definition into #ifdef

2018-12-10 Thread Arnd Bergmann
Marking the variable static showed that it's only used for SMP builds, as seen from this warning: kernel/sched/fair.c:119:21: error: 'capacity_margin' defined but not used [-Werror=unused-variable] static unsigned int capacity_margin = 1280; This has apparently been true since the variable