Re: [PATCH] sched: Remove nested extern

2014-09-24 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Wed, Sep 24, 2014 at 09:41:44AM +0200, Ingo Molnar wrote: > > > > * Rustad, Mark D wrote: > > > > > On Sep 22, 2014, at 2:21 PM, Peter Zijlstra wrote: > > > > > > > On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: > > > >> Because I have found

Re: [PATCH] sched: Remove nested extern

2014-09-24 Thread Peter Zijlstra
On Wed, Sep 24, 2014 at 09:41:44AM +0200, Ingo Molnar wrote: > > * Rustad, Mark D wrote: > > > On Sep 22, 2014, at 2:21 PM, Peter Zijlstra wrote: > > > > > On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: > > >> Because I have found that enabling many warnings helps identify

Re: [PATCH] sched: Remove nested extern

2014-09-24 Thread Ingo Molnar
* Rustad, Mark D wrote: > On Sep 22, 2014, at 2:21 PM, Peter Zijlstra wrote: > > > On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: > >> Because I have found that enabling many warnings helps identify problems > >> in code and it has been my standard practice since about 1999

Re: [PATCH] sched: Remove nested extern

2014-09-24 Thread Ingo Molnar
* Rustad, Mark D mark.d.rus...@intel.com wrote: On Sep 22, 2014, at 2:21 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: Because I have found that enabling many warnings helps identify problems in code and it has been my

Re: [PATCH] sched: Remove nested extern

2014-09-24 Thread Peter Zijlstra
On Wed, Sep 24, 2014 at 09:41:44AM +0200, Ingo Molnar wrote: * Rustad, Mark D mark.d.rus...@intel.com wrote: On Sep 22, 2014, at 2:21 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: Because I have found that enabling

Re: [PATCH] sched: Remove nested extern

2014-09-24 Thread Ingo Molnar
* Peter Zijlstra pet...@infradead.org wrote: On Wed, Sep 24, 2014 at 09:41:44AM +0200, Ingo Molnar wrote: * Rustad, Mark D mark.d.rus...@intel.com wrote: On Sep 22, 2014, at 2:21 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad,

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Rustad, Mark D
On Sep 22, 2014, at 2:21 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: >> Because I have found that enabling many warnings helps identify problems >> in code and it has been my standard practice since about 1999 to do so. >> The compiler warnings are

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Peter Zijlstra
On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: > Because I have found that enabling many warnings helps identify problems > in code and it has been my standard practice since about 1999 to do so. > The compiler warnings are really just another form of static analysis, > and I use

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Rustad, Mark D
On Sep 22, 2014, at 1:05 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 07:32:04PM +, Rustad, Mark D wrote: >> I assume that nested-externs is included in W=2 because many uses of >> them, especially with function prototypes, creates a risk of inconsistent >> declarations. The kernel

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Peter Zijlstra
On Mon, Sep 22, 2014 at 07:32:04PM +, Rustad, Mark D wrote: > On Sep 22, 2014, at 12:01 PM, Peter Zijlstra wrote: > > > On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: > >> Avoid W=2 nested-externs warning by moving the nested extern to > >> a normal extern. This eliminates

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Rustad, Mark D
On Sep 22, 2014, at 12:01 PM, Peter Zijlstra wrote: > On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: >> Avoid W=2 nested-externs warning by moving the nested extern to >> a normal extern. This eliminates that warning which is generated >> for every inclusion of sched.h in a

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Peter Zijlstra
On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: > Avoid W=2 nested-externs warning by moving the nested extern to > a normal extern. This eliminates that warning which is generated > for every inclusion of sched.h in a kernel build when W=2 is used. > This also removes a point of

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Josh Triplett
On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: > Avoid W=2 nested-externs warning by moving the nested extern to > a normal extern. This eliminates that warning which is generated > for every inclusion of sched.h in a kernel build when W=2 is used. > This also removes a point of

[PATCH] sched: Remove nested extern

2014-09-22 Thread Mark D Rustad
Avoid W=2 nested-externs warning by moving the nested extern to a normal extern. This eliminates that warning which is generated for every inclusion of sched.h in a kernel build when W=2 is used. This also removes a point of maintenance if the definition of delayacct_on were ever to change.

[PATCH] sched: Remove nested extern

2014-09-22 Thread Mark D Rustad
Avoid W=2 nested-externs warning by moving the nested extern to a normal extern. This eliminates that warning which is generated for every inclusion of sched.h in a kernel build when W=2 is used. This also removes a point of maintenance if the definition of delayacct_on were ever to change.

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Josh Triplett
On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: Avoid W=2 nested-externs warning by moving the nested extern to a normal extern. This eliminates that warning which is generated for every inclusion of sched.h in a kernel build when W=2 is used. This also removes a point of

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Peter Zijlstra
On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: Avoid W=2 nested-externs warning by moving the nested extern to a normal extern. This eliminates that warning which is generated for every inclusion of sched.h in a kernel build when W=2 is used. This also removes a point of

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Rustad, Mark D
On Sep 22, 2014, at 12:01 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: Avoid W=2 nested-externs warning by moving the nested extern to a normal extern. This eliminates that warning which is generated for every inclusion of

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Peter Zijlstra
On Mon, Sep 22, 2014 at 07:32:04PM +, Rustad, Mark D wrote: On Sep 22, 2014, at 12:01 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: Avoid W=2 nested-externs warning by moving the nested extern to a normal extern. This

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Rustad, Mark D
On Sep 22, 2014, at 1:05 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 07:32:04PM +, Rustad, Mark D wrote: I assume that nested-externs is included in W=2 because many uses of them, especially with function prototypes, creates a risk of inconsistent declarations.

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Peter Zijlstra
On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: Because I have found that enabling many warnings helps identify problems in code and it has been my standard practice since about 1999 to do so. The compiler warnings are really just another form of static analysis, and I use it

Re: [PATCH] sched: Remove nested extern

2014-09-22 Thread Rustad, Mark D
On Sep 22, 2014, at 2:21 PM, Peter Zijlstra pet...@infradead.org wrote: On Mon, Sep 22, 2014 at 08:59:32PM +, Rustad, Mark D wrote: Because I have found that enabling many warnings helps identify problems in code and it has been my standard practice since about 1999 to do so. The compiler