Re: [PATCH] scripts/Lindent: clean up and optimize

2016-08-07 Thread Joe Perches
On Sun, 2016-08-07 at 17:48 +0200, Jean Delvare wrote: > Hi Joe, > > On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote: > > > > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > > > > > > * Add a few blank lines to improve readability. > > > * Don't call cut 3 times when once is

Re: [PATCH] scripts/Lindent: clean up and optimize

2016-08-07 Thread Joe Perches
On Sun, 2016-08-07 at 17:48 +0200, Jean Delvare wrote: > Hi Joe, > > On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote: > > > > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > > > > > > * Add a few blank lines to improve readability. > > > * Don't call cut 3 times when once is

Re: [PATCH] scripts/Lindent: clean up and optimize

2016-08-07 Thread Jean Delvare
Hi Joe, On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote: > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > > * Add a few blank lines to improve readability. > > * Don't call cut 3 times when once is enough. > > * Drop a useless semicolon. > > As it commonly reflows > 80 column

Re: [PATCH] scripts/Lindent: clean up and optimize

2016-08-07 Thread Jean Delvare
Hi Joe, On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote: > On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > > * Add a few blank lines to improve readability. > > * Don't call cut 3 times when once is enough. > > * Drop a useless semicolon. > > As it commonly reflows > 80 column

Re: [PATCH] scripts/Lindent: clean up and optimize

2016-08-05 Thread Joe Perches
On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > * Add a few blank lines to improve readability. > * Don't call cut 3 times when once is enough. > * Drop a useless semicolon. As it commonly reflows > 80 column code very badly, my preference would be to remove Lindent instead.

Re: [PATCH] scripts/Lindent: clean up and optimize

2016-08-05 Thread Joe Perches
On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote: > * Add a few blank lines to improve readability. > * Don't call cut 3 times when once is enough. > * Drop a useless semicolon. As it commonly reflows > 80 column code very badly, my preference would be to remove Lindent instead.

[PATCH] scripts/Lindent: clean up and optimize

2016-08-05 Thread Jean Delvare
* Add a few blank lines to improve readability. * Don't call cut 3 times when once is enough. * Drop a useless semicolon. Signed-off-by: Jean Delvare --- scripts/Lindent | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) --- linux-4.7.orig/scripts/Lindent

[PATCH] scripts/Lindent: clean up and optimize

2016-08-05 Thread Jean Delvare
* Add a few blank lines to improve readability. * Don't call cut 3 times when once is enough. * Drop a useless semicolon. Signed-off-by: Jean Delvare --- scripts/Lindent | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) --- linux-4.7.orig/scripts/Lindent 2016-07-04