Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Sat, Mar 3, 2018 at 7:14 PM, Ulf Magnusson wrote: > On Sat, Mar 3, 2018 at 12:12 AM, Joey Pabalinas > wrote: >> On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: >>> Not sure this is an improvement. Zeroing the bytes after the

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Sat, Mar 3, 2018 at 7:14 PM, Ulf Magnusson wrote: > On Sat, Mar 3, 2018 at 12:12 AM, Joey Pabalinas > wrote: >> On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: >>> Not sure this is an improvement. Zeroing the bytes after the initial >>> null terminator is redundant, and the

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Sat, Mar 3, 2018 at 12:12 AM, Joey Pabalinas wrote: > On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: >> Not sure this is an improvement. Zeroing the bytes after the initial >> null terminator is redundant, and the explicit '\0' makes it clearer to >> me

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Sat, Mar 3, 2018 at 12:12 AM, Joey Pabalinas wrote: > On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: >> Not sure this is an improvement. Zeroing the bytes after the initial >> null terminator is redundant, and the explicit '\0' makes it clearer to >> me what's going on. > >

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: > Not sure this is an improvement. Zeroing the bytes after the initial > null terminator is redundant, and the explicit '\0' makes it clearer to > me what's going on. Yes, I agree with you, that is definitely quite true. This along

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: > Not sure this is an improvement. Zeroing the bytes after the initial > null terminator is redundant, and the explicit '\0' makes it clearer to > me what's going on. Yes, I agree with you, that is definitely quite true. This along

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Thu, Mar 01, 2018 at 09:44:24PM -1000, Joey Pabalinas wrote: > Convert strcat() calls which only append single characters > to the end of res into simpler (and most likely cheaper) > single assignment statements. > > Signed-off-by: Joey Pabalinas > > 1 file changed,

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Thu, Mar 01, 2018 at 09:44:24PM -1000, Joey Pabalinas wrote: > Convert strcat() calls which only append single characters > to the end of res into simpler (and most likely cheaper) > single assignment statements. > > Signed-off-by: Joey Pabalinas > > 1 file changed, 9 insertions(+), 10

[PATCH] scripts/kconfig: replace single character strcat() appends

Convert strcat() calls which only append single characters to the end of res into simpler (and most likely cheaper) single assignment statements. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scripts/kconfig/symbol.c

[PATCH] scripts/kconfig: replace single character strcat() appends

Convert strcat() calls which only append single characters to the end of res into simpler (and most likely cheaper) single assignment statements. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c