Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

On Fri, May 18, 2018 at 02:46:32PM +0900, Masahiro Yamada wrote: > Andrew picked it up, but this patch is *bad* > > You missed arch/Kconfig. > > $(cd "${tree}arch/" && echo *) > contains Kconfig, but it is not arch. That was also something that I found a bit weird myself, but I had assumed there

Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

2018-05-16 9:13 GMT+09:00 Joey Pabalinas : > Parsing `ls` is fragile at best and _will_ fail when $tree > contains spaces. Replace this with a glob-generated string > and directly assign it to $ALLSOURCE_ARCHS; use a subshell > so `cd` doesn't affect the current working directory. > > Signed-off-by

Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

On Tue, May 15, 2018 at 02:13:11PM -1000, Joey Pabalinas wrote: > and directly assign it to $ALLSOURCE_ARCHS; use a subshell > so `cd` doesn't affect the current working directory. Whoops, turns out the inner `()` isn't needed, so going to revise and send a v2. -- Cheers, Joey Pabalinas signat

[PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE_ARCHS generation

Parsing `ls` is fragile at best and _will_ fail when $tree contains spaces. Replace this with a glob-generated string and directly assign it to $ALLSOURCE_ARCHS; use a subshell so `cd` doesn't affect the current working directory. Signed-off-by: Joey Pabalinas 1 file changed, 1 insertion(+), 4