Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-19 Thread Hannes Reinecke
On 6/19/19 11:52 AM, Marcos Paulo de Souza wrote: > On Wed, Jun 19, 2019 at 08:34:56AM +0200, Hannes Reinecke wrote: >> On 6/19/19 5:35 AM, Martin K. Petersen wrote: >>> >>> Marcos, >>> WWID composed from VPD data from device, specifically page 0x83. So, when a device does not have VPD

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-19 Thread Marcos Paulo de Souza
On Wed, Jun 19, 2019 at 08:34:56AM +0200, Hannes Reinecke wrote: > On 6/19/19 5:35 AM, Martin K. Petersen wrote: > > > > Marcos, > > > >> WWID composed from VPD data from device, specifically page 0x83. So, > >> when a device does not have VPD support, for example USB storage > >> devices where

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-19 Thread Hannes Reinecke
On 6/19/19 5:35 AM, Martin K. Petersen wrote: > > Marcos, > >> WWID composed from VPD data from device, specifically page 0x83. So, >> when a device does not have VPD support, for example USB storage >> devices where VPD is specifically disabled, a read into > device>/device/wwid file will

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-18 Thread Martin K. Petersen
Marcos, > WWID composed from VPD data from device, specifically page 0x83. So, > when a device does not have VPD support, for example USB storage > devices where VPD is specifically disabled, a read into device>/device/wwid file will always return ENXIO. To avoid this, > change the

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-18 Thread Marcos Paulo de Souza
ping? Can anybody take a look at this patch? Thanks, Marcos On Tue, Jun 11, 2019 at 11:08:28PM -0300, Marcos Paulo de Souza wrote: > WWID composed from VPD data from device, specifically page 0x83. So, > when a device does not have VPD support, for example USB storage devices > where VPD is

[PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-11 Thread Marcos Paulo de Souza
WWID composed from VPD data from device, specifically page 0x83. So, when a device does not have VPD support, for example USB storage devices where VPD is specifically disabled, a read into /device/wwid file will always return ENXIO. To avoid this, change the scsi_sdev_attr_is_visible function to