Re: [PATCH] scsi: target: tcmu: Call flush_dcache_page() with proper page struct

2020-06-23 Thread Henry Willard
On 6/19/20 6:31 PM, kernel test robot wrote: Hi Henry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note.

Re: [PATCH] scsi: target: tcmu: Call flush_dcache_page() with proper page struct

2020-06-19 Thread kernel test robot
Hi Henry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] scsi: target: tcmu: Call flush_dcache_page() with proper page struct

2020-06-19 Thread Michael Christie
> On Jun 19, 2020, at 1:41 PM, Henry Willard wrote: > > tcmu_flush_dcache_range() gets called with addresses from both kernel > linear space and vmalloc space, so virt_to_page() or vmalloc_to_page() > have to be used as appropriate to get the proper page struct. On x86_64 >

[PATCH] scsi: target: tcmu: Call flush_dcache_page() with proper page struct

2020-06-19 Thread Henry Willard
tcmu_flush_dcache_range() gets called with addresses from both kernel linear space and vmalloc space, so virt_to_page() or vmalloc_to_page() have to be used as appropriate to get the proper page struct. On x86_64 flush_dcache_page() is the default noop implementation, so this hasn't been a problem