Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-28 Thread Steven Rostedt
On Tue, 27 Oct 2020 15:55:32 -0600 Shuah Khan wrote: > > Let me pull in the latest changes, and whip up a patch that works on both > > the older kernels as well as the newer ones. > > > > -- Steve > > > > Assume this is handled by > > selftests/ftrace: Use $FUNCTION_FORK to reference

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-28 Thread Steven Rostedt
On Tue, 27 Oct 2020 22:46:57 -0400 Steven Rostedt wrote: > Yep, that was the result of this thread. And if it's not clear. That thread supersedes this one. -- Steve

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-27 Thread Shuah Khan
On 10/23/20 9:51 AM, Steven Rostedt wrote: On Fri, 23 Oct 2020 11:49:48 -0400 Steven Rostedt wrote: On Fri, 23 Oct 2020 17:12:44 +0200 Alexander Gordeev wrote: Perhaps we should have: # older kernels have do_fork, but newer kernels have kernel_clone echo kernel_clone >>

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-26 Thread Steven Rostedt
On Sat, 24 Oct 2020 10:31:12 +0900 Masami Hiramatsu wrote: > > Perhaps we should have: > > > > # older kernels have do_fork, but newer kernels have kernel_clone > > echo kernel_clone >> set_ftrace_filter || echo *do_fork >> > > set_ftrace_filter > > Good catch. BTW, can we check the

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Masami Hiramatsu
On Fri, 23 Oct 2020 09:35:23 -0400 Steven Rostedt wrote: > On Fri, 23 Oct 2020 10:52:03 +0200 > Alexander Gordeev wrote: > > > diff --git > > a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > >

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Steven Rostedt
On Fri, 23 Oct 2020 11:49:48 -0400 Steven Rostedt wrote: > On Fri, 23 Oct 2020 17:12:44 +0200 > Alexander Gordeev wrote: > > > > Perhaps we should have: > > > > > > # older kernels have do_fork, but newer kernels have kernel_clone > > > echo kernel_clone >> set_ftrace_filter || echo

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Steven Rostedt
On Fri, 23 Oct 2020 17:12:44 +0200 Alexander Gordeev wrote: > > Perhaps we should have: > > > > # older kernels have do_fork, but newer kernels have kernel_clone > > echo kernel_clone >> set_ftrace_filter || echo *do_fork >> > > set_ftrace_filter > > Would you suggest to do the same

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Alexander Gordeev
On Fri, Oct 23, 2020 at 09:35:23AM -0400, Steven Rostedt wrote: > On Fri, 23 Oct 2020 10:52:03 +0200 > Alexander Gordeev wrote: > > > diff --git > > a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > >

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Steven Rostedt
On Fri, 23 Oct 2020 10:52:03 +0200 Alexander Gordeev wrote: > diff --git > a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-notrace-pid.tc > index acb17ce..0ddb948 100644 > ---

Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Masami Hiramatsu
On Fri, 23 Oct 2020 10:52:03 +0200 Alexander Gordeev wrote: > The _do_fork() is not completely removed from selftests > in favor of the kernel_clone(). > Looks good to me. Acked-by: Masami Hiramatsu Thank you! > Fixes: eea11285dab3 ("tracing: switch to kernel_clone()") > Cc: Steven Rostedt

[PATCH] selftests/ftrace: remove _do_fork() leftovers

2020-10-23 Thread Alexander Gordeev
The _do_fork() is not completely removed from selftests in favor of the kernel_clone(). Fixes: eea11285dab3 ("tracing: switch to kernel_clone()") Cc: Steven Rostedt Cc: Christian Brauner Cc: Masami Hiramatsu Signed-off-by: Alexander Gordeev ---