Re: [PATCH] selftests/lib: set printf.sh executable
Hi SeongJae Park, Thanks for the ping. On 06/24/2016 05:56 PM, SeongJae Park wrote: > Shuah, > > > May I ask your opinion about this patch? > > > Thanks, > SeongJae Park > > On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook wrote: >> On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park wrote: >>> Test for test_printf module fails always because the test program, >>> printf.sh, has no execution permission. This commit adds execution >>> permission to it. >>> >>> Signed-off-by: SeongJae Park >> >> Acked-by: Kees Cook >> >> (Is this mode change sufficient, or does the selftest infrastructure >> need to explicitly set it executable when running?) This is good and makes it consistent with bitmap.sh the other shell script in this test suite. I will get this into 4.8-rc1 thanks, -- Shuah >> >> -Kees >> >> >>> --- >>> tools/testing/selftests/lib/printf.sh | 0 >>> 1 file changed, 0 insertions(+), 0 deletions(-) >>> mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh >>> >>> diff --git a/tools/testing/selftests/lib/printf.sh >>> b/tools/testing/selftests/lib/printf.sh >>> old mode 100644 >>> new mode 100755 >>> -- >>> 1.9.1 >>> >> >> >> >> -- >> Kees Cook >> Chrome OS & Brillo Security
Re: [PATCH] selftests/lib: set printf.sh executable
Shuah, May I ask your opinion about this patch? Thanks, SeongJae Park On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook wrote: > On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park wrote: >> Test for test_printf module fails always because the test program, >> printf.sh, has no execution permission. This commit adds execution >> permission to it. >> >> Signed-off-by: SeongJae Park > > Acked-by: Kees Cook > > (Is this mode change sufficient, or does the selftest infrastructure > need to explicitly set it executable when running?) > > -Kees > > >> --- >> tools/testing/selftests/lib/printf.sh | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh >> >> diff --git a/tools/testing/selftests/lib/printf.sh >> b/tools/testing/selftests/lib/printf.sh >> old mode 100644 >> new mode 100755 >> -- >> 1.9.1 >> > > > > -- > Kees Cook > Chrome OS & Brillo Security
Re: [PATCH] selftests/lib: set printf.sh executable
On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park wrote: > Test for test_printf module fails always because the test program, > printf.sh, has no execution permission. This commit adds execution > permission to it. > > Signed-off-by: SeongJae Park Acked-by: Kees Cook (Is this mode change sufficient, or does the selftest infrastructure need to explicitly set it executable when running?) -Kees > --- > tools/testing/selftests/lib/printf.sh | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh > > diff --git a/tools/testing/selftests/lib/printf.sh > b/tools/testing/selftests/lib/printf.sh > old mode 100644 > new mode 100755 > -- > 1.9.1 > -- Kees Cook Chrome OS & Brillo Security
[PATCH] selftests/lib: set printf.sh executable
Test for test_printf module fails always because the test program, printf.sh, has no execution permission. This commit adds execution permission to it. Signed-off-by: SeongJae Park --- tools/testing/selftests/lib/printf.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh old mode 100644 new mode 100755 -- 1.9.1
