Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-09-09 Thread Shuah Khan
On 9/9/20 2:49 PM, Shuah Khan wrote: On 9/9/20 1:49 PM, Kees Cook wrote: On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote: Instead of full GNU diff (which smaller boot environments may not have), use "comm" which is more available. Reported-by: Naresh Kamboju Link:

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-09-09 Thread Kees Cook
On Wed, Sep 09, 2020 at 04:29:50PM -0400, Joe Lawrence wrote: > On 9/9/20 3:49 PM, Kees Cook wrote: > > > > On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote: > > > Instead of full GNU diff (which smaller boot environments may not have), > > > use "comm" which is more available. > > > >

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-09-09 Thread Shuah Khan
On 9/9/20 1:49 PM, Kees Cook wrote: On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote: Instead of full GNU diff (which smaller boot environments may not have), use "comm" which is more available. Reported-by: Naresh Kamboju Link:

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-09-09 Thread Joe Lawrence
On 9/9/20 3:49 PM, Kees Cook wrote: On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote: Instead of full GNU diff (which smaller boot environments may not have), use "comm" which is more available. Reported-by: Naresh Kamboju Link:

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-09-09 Thread Kees Cook
On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote: > Instead of full GNU diff (which smaller boot environments may not have), > use "comm" which is more available. > > Reported-by: Naresh Kamboju > Link: >

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-06-30 Thread Joe Lawrence
On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote: > Instead of full GNU diff (which smaller boot environments may not have), > use "comm" which is more available. > > Reported-by: Naresh Kamboju > Link: >

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-06-29 Thread Michael Ellerman
Kees Cook writes: > On Sat, Jun 27, 2020 at 09:51:31PM +1000, Michael Ellerman wrote: >> Kees Cook writes: >> > Instead of full GNU diff (which smaller boot environments may not have), >> > use "comm" which is more available. >> >> Although using "comm" requires CONFIG_PRINTK_TIME=y doesn't it?

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-06-27 Thread Kees Cook
On Sat, Jun 27, 2020 at 09:51:31PM +1000, Michael Ellerman wrote: > Kees Cook writes: > > Instead of full GNU diff (which smaller boot environments may not have), > > use "comm" which is more available. > > Although using "comm" requires CONFIG_PRINTK_TIME=y doesn't it? No, it doesn't seem to.

Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-06-27 Thread Michael Ellerman
Kees Cook writes: > Instead of full GNU diff (which smaller boot environments may not have), > use "comm" which is more available. Although using "comm" requires CONFIG_PRINTK_TIME=y doesn't it? Which is probably fine, but should be mentioned. And I guess for completeness you could add: diff

[PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg

2020-06-26 Thread Kees Cook
Instead of full GNU diff (which smaller boot environments may not have), use "comm" which is more available. Reported-by: Naresh Kamboju Link: https://lore.kernel.org/lkml/ca+g9fythp+gg+brr_gkbmxu2ooi-_e9pattpb6tvrswv1g1...@mail.gmail.com Fixes: f131d9edc29d ("selftests/lkdtm: Don't clear dmesg