Re: [PATCH] selftests: android: delete RUN_TESTS and EMIT_TESTS overrides

[Pintu Kumar]

On Thu, May 3, 2018 at 2:48 AM, Shuah Khan (Samsung OSG)
 wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) 
> ---
>  tools/testing/selftests/android/Makefile | 8 
>  1 file changed, 8 deletions(-)
>
> diff --git a/tools/testing/selftests/android/Makefile 
> b/tools/testing/selftests/android/Makefile
> index f6304d2be90c..72c25a3cb658 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -18,10 +18,6 @@ all:
> fi \
> done
>
> -override define RUN_TESTS
> -   @cd $(OUTPUT); ./run.sh
> -endef
> -
>  override define INSTALL_RULE
> mkdir -p $(INSTALL_PATH)
> install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) 
> $(TEST_FILES)
> @@ -33,10 +29,6 @@ override define INSTALL_RULE
> done;
>  endef
>
> -override define EMIT_TESTS
> -   echo "./run.sh"
> -endef
> -
>  override define CLEAN
> @for DIR in $(SUBDIRS); do  \
> BUILD_TARGET=$(OUTPUT)/$$DIR;   \
> --
> 2.14.1
>

OK.

Acked-by: Pintu Agarwal 

---

Note: This mail goes into my spam email box.

Re: [PATCH] selftests: android: delete RUN_TESTS and EMIT_TESTS overrides

[Pintu Kumar]

On Thu, May 3, 2018 at 2:48 AM, Shuah Khan (Samsung OSG)
 wrote:
> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
> lib.mk. Common defines work just fine and there is no need to define
> custom overrides.
>
> Signed-off-by: Shuah Khan (Samsung OSG) 
> ---
>  tools/testing/selftests/android/Makefile | 8 
>  1 file changed, 8 deletions(-)
>
> diff --git a/tools/testing/selftests/android/Makefile 
> b/tools/testing/selftests/android/Makefile
> index f6304d2be90c..72c25a3cb658 100644
> --- a/tools/testing/selftests/android/Makefile
> +++ b/tools/testing/selftests/android/Makefile
> @@ -18,10 +18,6 @@ all:
> fi \
> done
>
> -override define RUN_TESTS
> -   @cd $(OUTPUT); ./run.sh
> -endef
> -
>  override define INSTALL_RULE
> mkdir -p $(INSTALL_PATH)
> install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) 
> $(TEST_FILES)
> @@ -33,10 +29,6 @@ override define INSTALL_RULE
> done;
>  endef
>
> -override define EMIT_TESTS
> -   echo "./run.sh"
> -endef
> -
>  override define CLEAN
> @for DIR in $(SUBDIRS); do  \
> BUILD_TARGET=$(OUTPUT)/$$DIR;   \
> --
> 2.14.1
>

OK.

Acked-by: Pintu Agarwal 

---

Note: This mail goes into my spam email box.

[PATCH] selftests: android: delete RUN_TESTS and EMIT_TESTS overrides

[Shuah Khan (Samsung OSG)]

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
lib.mk. Common defines work just fine and there is no need to define
custom overrides.

Signed-off-by: Shuah Khan (Samsung OSG) 
---
 tools/testing/selftests/android/Makefile | 8 
 1 file changed, 8 deletions(-)

diff --git a/tools/testing/selftests/android/Makefile 
b/tools/testing/selftests/android/Makefile
index f6304d2be90c..72c25a3cb658 100644
--- a/tools/testing/selftests/android/Makefile
+++ b/tools/testing/selftests/android/Makefile
@@ -18,10 +18,6 @@ all:
fi \
done
 
-override define RUN_TESTS
-   @cd $(OUTPUT); ./run.sh
-endef
-
 override define INSTALL_RULE
mkdir -p $(INSTALL_PATH)
install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) 
$(TEST_FILES)
@@ -33,10 +29,6 @@ override define INSTALL_RULE
done;
 endef
 
-override define EMIT_TESTS
-   echo "./run.sh"
-endef
-
 override define CLEAN
@for DIR in $(SUBDIRS); do  \
BUILD_TARGET=$(OUTPUT)/$$DIR;   \
-- 
2.14.1

[PATCH] selftests: android: delete RUN_TESTS and EMIT_TESTS overrides

[Shuah Khan (Samsung OSG)]

Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
lib.mk. Common defines work just fine and there is no need to define
custom overrides.

Signed-off-by: Shuah Khan (Samsung OSG) 
---
 tools/testing/selftests/android/Makefile | 8 
 1 file changed, 8 deletions(-)

diff --git a/tools/testing/selftests/android/Makefile 
b/tools/testing/selftests/android/Makefile
index f6304d2be90c..72c25a3cb658 100644
--- a/tools/testing/selftests/android/Makefile
+++ b/tools/testing/selftests/android/Makefile
@@ -18,10 +18,6 @@ all:
fi \
done
 
-override define RUN_TESTS
-   @cd $(OUTPUT); ./run.sh
-endef
-
 override define INSTALL_RULE
mkdir -p $(INSTALL_PATH)
install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) 
$(TEST_FILES)
@@ -33,10 +29,6 @@ override define INSTALL_RULE
done;
 endef
 
-override define EMIT_TESTS
-   echo "./run.sh"
-endef
-
 override define CLEAN
@for DIR in $(SUBDIRS); do  \
BUILD_TARGET=$(OUTPUT)/$$DIR;   \
-- 
2.14.1