Re: [PATCH] selinux: Fix bool initialization/comparison

2017-10-13 Thread Paul Moore
On Tue, Oct 10, 2017 at 7:19 PM, Casey Schaufler wrote: > On 10/7/2017 7:02 AM, Thomas Meyer wrote: >> Bool initializations should use true and false. Bool tests don't need >> comparisons. >> >> Signed-off-by: Thomas Meyer >> --- Hi Thomas, Thank you

Re: [PATCH] selinux: Fix bool initialization/comparison

2017-10-13 Thread Paul Moore
On Tue, Oct 10, 2017 at 7:19 PM, Casey Schaufler wrote: > On 10/7/2017 7:02 AM, Thomas Meyer wrote: >> Bool initializations should use true and false. Bool tests don't need >> comparisons. >> >> Signed-off-by: Thomas Meyer >> --- Hi Thomas, Thank you for submitting this patch, but it really

Re: [PATCH] selinux: Fix bool initialization/comparison

2017-10-10 Thread Casey Schaufler
On 10/7/2017 7:02 AM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c > --- a/security/selinux/ss/mls.c > +++

Re: [PATCH] selinux: Fix bool initialization/comparison

2017-10-10 Thread Casey Schaufler
On 10/7/2017 7:02 AM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c > --- a/security/selinux/ss/mls.c > +++

Re: [PATCH] selinux: Fix bool initialization/comparison

2017-10-10 Thread Casey Schaufler
On 10/7/2017 7:02 AM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c > --- a/security/selinux/ss/mls.c > +++

Re: [PATCH] selinux: Fix bool initialization/comparison

2017-10-10 Thread Casey Schaufler
On 10/7/2017 7:02 AM, Thomas Meyer wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c > --- a/security/selinux/ss/mls.c > +++

[PATCH] selinux: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c --- a/security/selinux/ss/mls.c +++ b/security/selinux/ss/mls.c @@ -550,7 +550,7 @@ int

[PATCH] selinux: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c --- a/security/selinux/ss/mls.c +++ b/security/selinux/ss/mls.c @@ -550,7 +550,7 @@ int mls_compute_sid(struct