Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Mike Galbraith
On Tue, 2016-10-25 at 08:25 -0500, Rob Herring wrote: > On Tue, Oct 25, 2016 at 7:55 AM, Mike Galbraith > wrote: > > On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > > > > > Mike: I see you are using a PC, while I'm using an ARM board (with DT). > > > Are

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Mike Galbraith
On Tue, 2016-10-25 at 08:25 -0500, Rob Herring wrote: > On Tue, Oct 25, 2016 at 7:55 AM, Mike Galbraith > wrote: > > On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > > > > > Mike: I see you are using a PC, while I'm using an ARM board (with DT). > > > Are you using a serial

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Rob Herring
On Tue, Oct 25, 2016 at 7:55 AM, Mike Galbraith wrote: > On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > >> Mike: I see you are using a PC, while I'm using an ARM board (with DT). >> Are you using a serial console? If yes, what's the value of port->console

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Rob Herring
On Tue, Oct 25, 2016 at 7:55 AM, Mike Galbraith wrote: > On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > >> Mike: I see you are using a PC, while I'm using an ARM board (with DT). >> Are you using a serial console? If yes, what's the value of port->console >> before and after the

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Mike Galbraith
On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > Mike: I see you are using a PC, while I'm using an ARM board (with DT). > Are you using a serial console? If yes, what's the value of port->console > before and after the call to uart_console() that Rob's patch below removes? Well,

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Mike Galbraith
On Tue, 2016-10-25 at 12:40 +0200, Geert Uytterhoeven wrote: > Mike: I see you are using a PC, while I'm using an ARM board (with DT). > Are you using a serial console? If yes, what's the value of port->console > before and after the call to uart_console() that Rob's patch below removes? Well,

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Geert Uytterhoeven
Hi Rob, On Mon, Oct 24, 2016 at 10:56 PM, Rob Herring wrote: > Commit 761ed4a94582 ('tty: serial_core: convert uart_close to use > tty_port_close') started setting the ttyport console flag for serial > drivers. This is causing crashes, hangs, or garbage output on several >

Re: [PATCH] serial: core: fix console problems on uart_close

2016-10-25 Thread Geert Uytterhoeven
Hi Rob, On Mon, Oct 24, 2016 at 10:56 PM, Rob Herring wrote: > Commit 761ed4a94582 ('tty: serial_core: convert uart_close to use > tty_port_close') started setting the ttyport console flag for serial > drivers. This is causing crashes, hangs, or garbage output on several > platforms because the

[PATCH] serial: core: fix console problems on uart_close

2016-10-24 Thread Rob Herring
Commit 761ed4a94582 ('tty: serial_core: convert uart_close to use tty_port_close') started setting the ttyport console flag for serial drivers. This is causing crashes, hangs, or garbage output on several platforms because the serial shutdown is skipped and IRQs are left enabled. Partially revert

[PATCH] serial: core: fix console problems on uart_close

2016-10-24 Thread Rob Herring
Commit 761ed4a94582 ('tty: serial_core: convert uart_close to use tty_port_close') started setting the ttyport console flag for serial drivers. This is causing crashes, hangs, or garbage output on several platforms because the serial shutdown is skipped and IRQs are left enabled. Partially revert