Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Bernd Petrovitsch
On Thu, 2005-07-28 at 11:40 +0100, Paulo Marques wrote: [...] > You're comming really late in this thread :) Well, the same issue arised recently somewhere else too on this list and lots of C programmers (not only beginners) don't know about the 3 char types as speficied in the C standard. [ The

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Paulo Marques
Bernd Petrovitsch wrote: On Thu, 2005-07-28 at 11:02 +0100, Paulo Marques wrote: J.A. Magallon wrote: [...] All the problems are born here: struct sym_entry { unsigned long long addr; unsigned int len; unsigned char *sym; }; What are you guys talking about? "unsigned char *" is

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Bernd Petrovitsch
On Thu, 2005-07-28 at 11:02 +0100, Paulo Marques wrote: > J.A. Magallon wrote: > > On 07.27, Sam Ravnborg wrote: > >>On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: > >>>On 07.16, J.A. Magallon wrote: > On 07.15, Andrew Morton wrote: > >

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Paulo Marques
J.A. Magallon wrote: On 07.27, Sam Ravnborg wrote: On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ This time I did not

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Paulo Marques
J.A. Magallon wrote: On 07.27, Sam Ravnborg wrote: On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ This time I did not

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Bernd Petrovitsch
On Thu, 2005-07-28 at 11:02 +0100, Paulo Marques wrote: J.A. Magallon wrote: On 07.27, Sam Ravnborg wrote: On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote:

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Paulo Marques
Bernd Petrovitsch wrote: On Thu, 2005-07-28 at 11:02 +0100, Paulo Marques wrote: J.A. Magallon wrote: [...] All the problems are born here: struct sym_entry { unsigned long long addr; unsigned int len; unsigned char *sym; }; What are you guys talking about? unsigned char * is

Re: [PATCH] signed char fixes for scripts

2005-07-28 Thread Bernd Petrovitsch
On Thu, 2005-07-28 at 11:40 +0100, Paulo Marques wrote: [...] You're comming really late in this thread :) Well, the same issue arised recently somewhere else too on this list and lots of C programmers (not only beginners) don't know about the 3 char types as speficied in the C standard. [ The C

Re: [PATCH] signed char fixes for scripts

2005-07-27 Thread J.A. Magallon
On 07.27, Sam Ravnborg wrote: > On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: > > > > On 07.16, J.A. Magallon wrote: > > > > > > On 07.15, Andrew Morton wrote: > > > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ > > > > > >

Re: [PATCH] signed char fixes for scripts

2005-07-27 Thread Sam Ravnborg
On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: > > On 07.16, J.A. Magallon wrote: > > > > On 07.15, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ > > > > > This time I did not break anything... and

Re: [PATCH] signed char fixes for scripts

2005-07-27 Thread Sam Ravnborg
On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ This time I did not break anything... and they shut up gcc4 ;)

Re: [PATCH] signed char fixes for scripts

2005-07-27 Thread J.A. Magallon
On 07.27, Sam Ravnborg wrote: On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ This time I did not

Re: [PATCH] signed char fixes for scripts

2005-07-18 Thread Paulo Marques
Paulo Marques wrote: Sam Ravnborg wrote: [...] Also this patch seems relative small compared to the others floating around to cure signed warnings in scripts/ Does this really fix all of them or only a subset of the warnings? Well, current -linus already has a patch from me to change the

Re: [PATCH] signed char fixes for scripts

2005-07-18 Thread Paulo Marques
Sam Ravnborg wrote: On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: [...] This time I did not break anything... and they shut up gcc4 ;) Thanks. Can you please resend with proper changelog and signed-off-by. Diff should be done on top of latest

Re: [PATCH] signed char fixes for scripts

2005-07-18 Thread Paulo Marques
Sam Ravnborg wrote: On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: [...] This time I did not break anything... and they shut up gcc4 ;) Thanks. Can you please resend with proper changelog and signed-off-by. Diff should be done on top of latest

Re: [PATCH] signed char fixes for scripts

2005-07-18 Thread Paulo Marques
Paulo Marques wrote: Sam Ravnborg wrote: [...] Also this patch seems relative small compared to the others floating around to cure signed warnings in scripts/ Does this really fix all of them or only a subset of the warnings? Well, current -linus already has a patch from me to change the

Re: [PATCH] signed char fixes for scripts

2005-07-16 Thread Sam Ravnborg
On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: > > On 07.16, J.A. Magallon wrote: > > > > On 07.15, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ > > > > > This time I did not break anything... and

Re: [PATCH] signed char fixes for scripts

2005-07-16 Thread Sam Ravnborg
On Fri, Jul 15, 2005 at 10:14:43PM +, J.A. Magallon wrote: On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ This time I did not break anything... and they shut up gcc4 ;)

[PATCH] signed char fixes for scripts

2005-07-15 Thread J.A. Magallon
On 07.16, J.A. Magallon wrote: > > On 07.15, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ > > This time I did not break anything... and they shut up gcc4 ;) --- linux-2.6.12-jam1/scripts/mod/sumversion.c.orig

[PATCH] signed char fixes for scripts

2005-07-15 Thread J.A. Magallon
On 07.16, J.A. Magallon wrote: On 07.15, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ This time I did not break anything... and they shut up gcc4 ;) --- linux-2.6.12-jam1/scripts/mod/sumversion.c.orig 2005-06-21