and s are in all possible
> contexts. Sheesh.
Hi, David,
Although it's rather a matter of personal preference, I tend to agree
with you.
Andrew,
The fix by David Rientjes is attached. It's up to you to decide, which
one looks better.
Thank you and sorry about the noise.
>From 371649294d90b65
00:00:00 2001
From: David Rientjes rient...@google.com
Date: Sun, 26 Jan 2014 11:49:39 +0400
Subject: [PATCH] slab: fix wrong retval on kmem_cache_create_memcg error path
On kmem_cache_create_memcg() error path we set 'err', but leave 's' (the
new cache ptr) undefined. The latter can be NULL if we
On Sat, 25 Jan 2014, Vladimir Davydov wrote:
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 8e40321..499b53c 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -249,7 +249,6 @@ out_unlock:
> name, err);
> dump_stack();
>
On Sat, 25 Jan 2014, Vladimir Davydov wrote:
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 8e40321..499b53c 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -249,7 +249,6 @@ out_unlock:
name, err);
dump_stack();
From: Dave Jones
On kmem_cache_create_memcg() error path we set 'err', but leave 's' (the
new cache ptr) undefined. The latter can be NULL if we could not
allocate the cache, or pointing to a freed area if we failed somewhere
later while trying to initialize it. Initially we checked 'err'
From: Dave Jones da...@redhat.com
On kmem_cache_create_memcg() error path we set 'err', but leave 's' (the
new cache ptr) undefined. The latter can be NULL if we could not
allocate the cache, or pointing to a freed area if we failed somewhere
later while trying to initialize it. Initially we
6 matches
Mail list logo
