Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-26 Thread Christoph Lameter
On Mon, 24 Dec 2007, Pekka Enberg wrote: > On Dec 24, 2007 9:12 PM, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > Hmmm... What is the combination of config variables that causes this? I > > moved the count_partial function in mm in order to make the merge of slab > > defrag easier. > > I

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-26 Thread Christoph Lameter
On Mon, 24 Dec 2007, Pekka Enberg wrote: On Dec 24, 2007 9:12 PM, Christoph Lameter [EMAIL PROTECTED] wrote: Hmmm... What is the combination of config variables that causes this? I moved the count_partial function in mm in order to make the merge of slab defrag easier. I think it's

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-24 Thread Pekka Enberg
On Dec 24, 2007 9:12 PM, Christoph Lameter <[EMAIL PROTECTED]> wrote: > Hmmm... What is the combination of config variables that causes this? I > moved the count_partial function in mm in order to make the merge of slab > defrag easier. I think it's CONFIG_PROC_FS without CONFIG_SYSFS. -- To

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-24 Thread Christoph Lameter
On Sat, 22 Dec 2007, Ingo Molnar wrote: > Pekka, i stuck your patch into the x86.git random-test-grid, and it > found the following build error after a few iterations: > > mm/slub.c: In function 's_show': > mm/slub.c:4188: error: implicit declaration of function 'count_partial' > > find

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-24 Thread Christoph Lameter
On Sat, 22 Dec 2007, Ingo Molnar wrote: Pekka, i stuck your patch into the x86.git random-test-grid, and it found the following build error after a few iterations: mm/slub.c: In function 's_show': mm/slub.c:4188: error: implicit declaration of function 'count_partial' find the

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-24 Thread Pekka Enberg
On Dec 24, 2007 9:12 PM, Christoph Lameter [EMAIL PROTECTED] wrote: Hmmm... What is the combination of config variables that causes this? I moved the count_partial function in mm in order to make the merge of slab defrag easier. I think it's CONFIG_PROC_FS without CONFIG_SYSFS. -- To

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka Enberg
Hi Ingo, On Dec 22, 2007 3:40 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > ah, didnt see that. Could you pick up bits of my patch because it seems > to do a better job, such as proper c99 initializer: [snip] > also, my patch fixes all the warnings as well, not just the errors. So > please give

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Pekka Enberg <[EMAIL PROTECTED]> wrote: > Hi Ingo, > > On Dec 22, 2007 3:14 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > Also please apply the cleanup patch below, it fixes 34 checkpatch errors > > and warnings in mm/slub.c. > > Those are already fixed in -mm: > >

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka Enberg
Hi Ingo, On Dec 22, 2007 3:37 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > Pekka, i stuck your patch into the x86.git random-test-grid, and it > found the following build error after a few iterations: > > mm/slub.c: In function 's_show': > mm/slub.c:4188: error: implicit declaration of

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > From: Pekka Enberg <[EMAIL PROTECTED]> > > > > This adds a read-only /proc/slabinfo file that is ABI compatible with > > SLAB for SLUB. > > > > Cc: Ingo Molnar <[EMAIL PROTECTED]> > > Tested-by: Ingo Molnar <[EMAIL PROTECTED]> Pekka, i stuck your

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka Enberg
Hi Ingo, On Dec 22, 2007 3:14 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > Also please apply the cleanup patch below, it fixes 34 checkpatch errors > and warnings in mm/slub.c. Those are already fixed in -mm:

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Pekka J Enberg <[EMAIL PROTECTED]> wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > This adds a read-only /proc/slabinfo file that is ABI compatible with > SLAB for SLUB. > > Cc: Ingo Molnar <[EMAIL PROTECTED]> Tested-by: Ingo Molnar <[EMAIL PROTECTED]> Ingo -- To unsubscribe

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Pekka J Enberg <[EMAIL PROTECTED]> wrote: > From: Pekka Enberg <[EMAIL PROTECTED]> > > This adds a read-only /proc/slabinfo file that is ABI compatible with > SLAB for SLUB. cool :-) I tried your patch and slabtop works just fine: --> Active / Total Objects (% used):

[PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> This adds a read-only /proc/slabinfo file that is ABI compatible with SLAB for SLUB. Cc: Ingo Molnar <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Cc: Christoph Lameter <[EMAIL PROTECTED]> Cc: Peter Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Pekka

[PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka J Enberg
From: Pekka Enberg [EMAIL PROTECTED] This adds a read-only /proc/slabinfo file that is ABI compatible with SLAB for SLUB. Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Andi Kleen [EMAIL PROTECTED] Cc: Christoph Lameter [EMAIL PROTECTED] Cc: Peter Zijlstra [EMAIL PROTECTED] Signed-off-by: Pekka Enberg

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Pekka J Enberg [EMAIL PROTECTED] wrote: From: Pekka Enberg [EMAIL PROTECTED] This adds a read-only /proc/slabinfo file that is ABI compatible with SLAB for SLUB. cool :-) I tried your patch and slabtop works just fine: -- Active / Total Objects (% used): 31939 /

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Pekka J Enberg [EMAIL PROTECTED] wrote: From: Pekka Enberg [EMAIL PROTECTED] This adds a read-only /proc/slabinfo file that is ABI compatible with SLAB for SLUB. Cc: Ingo Molnar [EMAIL PROTECTED] Tested-by: Ingo Molnar [EMAIL PROTECTED] Ingo -- To unsubscribe from this list:

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka Enberg
Hi Ingo, On Dec 22, 2007 3:14 PM, Ingo Molnar [EMAIL PROTECTED] wrote: Also please apply the cleanup patch below, it fixes 34 checkpatch errors and warnings in mm/slub.c. Those are already fixed in -mm:

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: From: Pekka Enberg [EMAIL PROTECTED] This adds a read-only /proc/slabinfo file that is ABI compatible with SLAB for SLUB. Cc: Ingo Molnar [EMAIL PROTECTED] Tested-by: Ingo Molnar [EMAIL PROTECTED] Pekka, i stuck your patch into the

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka Enberg
Hi Ingo, On Dec 22, 2007 3:37 PM, Ingo Molnar [EMAIL PROTECTED] wrote: Pekka, i stuck your patch into the x86.git random-test-grid, and it found the following build error after a few iterations: mm/slub.c: In function 's_show': mm/slub.c:4188: error: implicit declaration of function

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Ingo Molnar
* Pekka Enberg [EMAIL PROTECTED] wrote: Hi Ingo, On Dec 22, 2007 3:14 PM, Ingo Molnar [EMAIL PROTECTED] wrote: Also please apply the cleanup patch below, it fixes 34 checkpatch errors and warnings in mm/slub.c. Those are already fixed in -mm:

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-22 Thread Pekka Enberg
Hi Ingo, On Dec 22, 2007 3:40 PM, Ingo Molnar [EMAIL PROTECTED] wrote: ah, didnt see that. Could you pick up bits of my patch because it seems to do a better job, such as proper c99 initializer: [snip] also, my patch fixes all the warnings as well, not just the errors. So please give it a