Re: [PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-30 Thread Christoph Lameter
On Sat, 28 Jul 2012, JoonSoo Kim wrote: > 2012/7/28 Christoph Lameter : > > On Sat, 28 Jul 2012, Joonsoo Kim wrote: > > > >> Subject and commit log are changed from v1. > > > > That looks a bit better. But the changelog could use more cleanup and > > clearer expression. > > > >> @@ -2490,25

Re: [PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-30 Thread Christoph Lameter
On Sat, 28 Jul 2012, JoonSoo Kim wrote: 2012/7/28 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, Joonsoo Kim wrote: Subject and commit log are changed from v1. That looks a bit better. But the changelog could use more cleanup and clearer expression. @@ -2490,25 +2492,17

Re: [PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-28 Thread JoonSoo Kim
2012/7/28 Christoph Lameter : > On Sat, 28 Jul 2012, Joonsoo Kim wrote: > >> Subject and commit log are changed from v1. > > That looks a bit better. But the changelog could use more cleanup and > clearer expression. > >> @@ -2490,25 +2492,17 @@ static void __slab_free(struct kmem_cache *s, struct

Re: [PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-28 Thread JoonSoo Kim
2012/7/28 Christoph Lameter c...@linux.com: On Sat, 28 Jul 2012, Joonsoo Kim wrote: Subject and commit log are changed from v1. That looks a bit better. But the changelog could use more cleanup and clearer expression. @@ -2490,25 +2492,17 @@ static void __slab_free(struct kmem_cache *s,

Re: [PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-27 Thread Christoph Lameter
On Sat, 28 Jul 2012, Joonsoo Kim wrote: > Subject and commit log are changed from v1. That looks a bit better. But the changelog could use more cleanup and clearer expression. > @@ -2490,25 +2492,17 @@ static void __slab_free(struct kmem_cache *s, struct > page *page, >

[PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-27 Thread Joonsoo Kim
When we try to free object, there is some of case that we need to take a node lock. This is the necessary step for preventing a race. After taking a lock, then we try to cmpxchg_double_slab(). But, there is a possible scenario that cmpxchg_double_slab() is failed. Following example explains this.

[PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-27 Thread Joonsoo Kim
When we try to free object, there is some of case that we need to take a node lock. This is the necessary step for preventing a race. After taking a lock, then we try to cmpxchg_double_slab(). But, there is a possible scenario that cmpxchg_double_slab() is failed. Following example explains this.

Re: [PATCH] slub: remove one code path and reduce lock contention in __slab_free()

2012-07-27 Thread Christoph Lameter
On Sat, 28 Jul 2012, Joonsoo Kim wrote: Subject and commit log are changed from v1. That looks a bit better. But the changelog could use more cleanup and clearer expression. @@ -2490,25 +2492,17 @@ static void __slab_free(struct kmem_cache *s, struct page *page, return;