Re: [PATCH] soc: aspeed: lpc-ctrl: Fix probe error handling

2019-06-21 Thread Vijay Khemka
On 6/20/19, 2:17 AM, "joel.s...@gmail.com on behalf of Joel Stanley" wrote: gcc warns that a mising "flash" phandle node leads to undefined behavior later: drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe':

Re: [PATCH] soc: aspeed: lpc-ctrl: Fix probe error handling

2019-06-20 Thread Andrew Jeffery
On Thu, 20 Jun 2019, at 18:47, Joel Stanley wrote: > gcc warns that a mising "flash" phandle node leads to undefined > behavior later: > > drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function > 'aspeed_lpc_ctrl_probe': > drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void > *)+8)' may

[PATCH] soc: aspeed: lpc-ctrl: Fix probe error handling

2019-06-20 Thread Joel Stanley
gcc warns that a mising "flash" phandle node leads to undefined behavior later: drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]