Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe

2019-06-18 Thread Olof Johansson
On Tue, Jun 18, 2019 at 02:54:10PM +0300, Dan Carpenter wrote: > The devm_ioremap_resource() function doesn't return NULL, it returns > error pointers. > > Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") > Signed-off-by: Dan Carpenter > Reviewed-by: Linus Walleij Applied,

[PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe

2019-06-18 Thread Dan Carpenter
The devm_ioremap_resource() function doesn't return NULL, it returns error pointers. Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij --- drivers/soc/ixp4xx/ixp4xx-npe.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe

2019-06-18 Thread Linus Walleij
On Thu, Jun 13, 2019 at 9:02 AM Dan Carpenter wrote: > The devm_ioremap_resource() function doesn't return NULL, it returns > error pointers. > > Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") > Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Can you please

[PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe

2019-06-13 Thread Dan Carpenter
The devm_ioremap_resource() function doesn't return NULL, it returns error pointers. Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources") Signed-off-by: Dan Carpenter --- drivers/soc/ixp4xx/ixp4xx-npe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git