Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-06-22 09:54:54) > On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > > > This macro doesn't work, because it hides a local variable inside of the > > macro to hold the version and that variable name is called 'ver' and > > 'version' sometimes. > > > > Let's change

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-06-22 09:54:54) > On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > > > This macro doesn't work, because it hides a local variable inside of the > > macro to hold the version and that variable name is called 'ver' and > > 'version' sometimes. > > > > Let's change

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Bjorn Andersson
On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > This macro doesn't work, because it hides a local variable inside of the > macro to hold the version and that variable name is called 'ver' and > 'version' sometimes. > > Let's change this to be more explicit. Introduce three macros for the >

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-06-22 Thread Bjorn Andersson
On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote: > This macro doesn't work, because it hides a local variable inside of the > macro to hold the version and that variable name is called 'ver' and > 'version' sometimes. > > Let's change this to be more explicit. Introduce three macros for the >

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-05-21 Thread Doug Anderson
Hi, On Fri, May 18, 2018 at 3:47 PM, Stephen Boyd wrote: > This macro doesn't work, because it hides a local variable inside of the > macro to hold the version and that variable name is called 'ver' and > 'version' sometimes. > > Let's change this to be more explicit.

Re: [PATCH] soc: qcom: geni: Make version macros simpler

2018-05-21 Thread Doug Anderson
Hi, On Fri, May 18, 2018 at 3:47 PM, Stephen Boyd wrote: > This macro doesn't work, because it hides a local variable inside of the > macro to hold the version and that variable name is called 'ver' and > 'version' sometimes. > > Let's change this to be more explicit. Introduce three macros for

[PATCH] soc: qcom: geni: Make version macros simpler

2018-05-18 Thread Stephen Boyd
This macro doesn't work, because it hides a local variable inside of the macro to hold the version and that variable name is called 'ver' and 'version' sometimes. Let's change this to be more explicit. Introduce three macros for the major, minor, and step of the version, and require callers to

[PATCH] soc: qcom: geni: Make version macros simpler

2018-05-18 Thread Stephen Boyd
This macro doesn't work, because it hides a local variable inside of the macro to hold the version and that variable name is called 'ver' and 'version' sometimes. Let's change this to be more explicit. Introduce three macros for the major, minor, and step of the version, and require callers to