Re: [PATCH] soc: qcom: smd: Reject send of too big packets

[Andy Gross]

On Thu, Sep 24, 2015 at 06:37:18PM -0700, Bjorn Andersson wrote:
> Attempting to find room for a packet that's bigger than the fifo will
> never succeed and the calling process will be sleeping forever in the
> loop, waiting for enough room. So fail early instead.
> 
> Reported-by: Courtney Cavin 
> Signed-off-by: Bjorn Andersson 
> ---

Looks reasonable.

Reviewed-by: Andy Gross 

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] soc: qcom: smd: Reject send of too big packets

[Andy Gross]

On Thu, Sep 24, 2015 at 06:37:18PM -0700, Bjorn Andersson wrote:
> Attempting to find room for a packet that's bigger than the fifo will
> never succeed and the calling process will be sleeping forever in the
> loop, waiting for enough room. So fail early instead.
> 
> Reported-by: Courtney Cavin 
> Signed-off-by: Bjorn Andersson 
> ---

Looks reasonable.

Reviewed-by: Andy Gross 

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] soc: qcom: smd: Reject send of too big packets

[Bjorn Andersson]

Attempting to find room for a packet that's bigger than the fifo will
never succeed and the calling process will be sleeping forever in the
loop, waiting for enough room. So fail early instead.

Reported-by: Courtney Cavin 
Signed-off-by: Bjorn Andersson 
---
 drivers/soc/qcom/smd.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index 18964f154383..88353bda1ea4 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -723,6 +723,10 @@ int qcom_smd_send(struct qcom_smd_channel *channel, const 
void *data, int len)
if (channel->info_word && len % 4)
return -EINVAL;
 
+   /* Reject packets that are too big */
+   if (tlen >= channel->fifo_size)
+   return -EINVAL;
+
ret = mutex_lock_interruptible(>tx_lock);
if (ret)
return ret;
-- 
1.8.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] soc: qcom: smd: Reject send of too big packets

[Bjorn Andersson]

Attempting to find room for a packet that's bigger than the fifo will
never succeed and the calling process will be sleeping forever in the
loop, waiting for enough room. So fail early instead.

Reported-by: Courtney Cavin 
Signed-off-by: Bjorn Andersson 
---
 drivers/soc/qcom/smd.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index 18964f154383..88353bda1ea4 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -723,6 +723,10 @@ int qcom_smd_send(struct qcom_smd_channel *channel, const 
void *data, int len)
if (channel->info_word && len % 4)
return -EINVAL;
 
+   /* Reject packets that are too big */
+   if (tlen >= channel->fifo_size)
+   return -EINVAL;
+
ret = mutex_lock_interruptible(>tx_lock);
if (ret)
return ret;
-- 
1.8.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/