Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread santosh.shilim...@oracle.com
On 10/30/18 12:00 PM, Greg Kroah-Hartman wrote: On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote: Hi Greg, [...] Would be able to apply this fix from Marc for stable or it needs to be re-posted with CC to stable ? This is not the correct way to submit patches for inclusi

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Greg Kroah-Hartman
On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote: > Hi Greg, > > On 10/30/2018 4:11 AM, Marc Zyngier wrote: > > The Keystone QMSS driver is pretty damaged, in the sense that it > > does things like this: > > > > irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); > > > > where

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Marc Zyngier
On 30/10/18 17:02, Florian Fainelli wrote: > On 10/30/18 4:11 AM, Marc Zyngier wrote: >> The Keystone QMSS driver is pretty damaged, in the sense that it >> does things like this: >> >> irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); >> >> where cpu_map is a local variable. As we leave the f

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Greg, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, an

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Arnd, Olof, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-la

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and things will

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Florian Fainelli
On 10/30/18 4:11 AM, Marc Zyngier wrote: > The Keystone QMSS driver is pretty damaged, in the sense that it > does things like this: > > irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); > > where cpu_map is a local variable. As we leave the function, this > will point to nowhere-land, and

[PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Marc Zyngier
The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and things will end-up badly. Instead, let's use a prope