RE: [EXT] Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-13 Thread Jiafei Pan
> > Best Regards, > > Jiafei. > > > > -Original Message- > > From: Jiafei Pan > > Sent: Thursday, August 6, 2020 12:07 PM > > To: pet...@infradead.org; mi...@kernel.org; t...@linutronix.de; > > rost...@goodmis.org; romain.per...@

RE: [EXT] Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-13 Thread Jiafei Pan
> From: Peter Zijlstra > Sent: Thursday, August 13, 2020 1:58 PM > > On Thu, Aug 06, 2020 at 12:07:29PM +0800, Jiafei Pan wrote: > > __raise_softirq_irqoff will update per-CPU mask of pending softirqs, > > it need to be called in irq disabled context in order to keep it > > atomic operation,

Re: [EXT] Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-13 Thread Steven Rostedt
On Fri, 14 Aug 2020 02:21:25 + Jiafei Pan wrote: > > This is probably more for Thomas Gleixner. > Thanks Steven. > @Thomas Gleixner, would you please review the patch? thanks. > Jiafei. I believe he already did. -- Steve

RE: [EXT] Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-13 Thread Jiafei Pan
st 6, 2020 12:07 PM > To: pet...@infradead.org; mi...@kernel.org; t...@linutronix.de; > rost...@goodmis.org; romain.per...@gmail.com; w...@kernel.org > Cc: linux-kernel@vger.kernel.org; linux-rt-us...@vger.kernel.org; > Jiafei Pan ; Leo Li ; Vladimir > Oltean ; Jiafei Pan > S

Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-13 Thread Steven Rostedt
> rost...@goodmis.org; romain.per...@gmail.com; w...@kernel.org > Cc: linux-kernel@vger.kernel.org; linux-rt-us...@vger.kernel.org; Jiafei Pan > ; Leo Li ; Vladimir Oltean > ; Jiafei Pan > Subject: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff > > __raise_softirq_irqo

Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-13 Thread Thomas Gleixner
Jiafei Pan writes: > __raise_softirq_irqoff will update per-CPU mask of pending softirqs, Please write __raise_softirq_irqoff() so it's clear that this is about a function. > void __raise_softirq_irqoff(unsigned int nr) > { > + /* This function can only be called in irq disabled context,

Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-12 Thread Peter Zijlstra
On Thu, Aug 06, 2020 at 12:07:29PM +0800, Jiafei Pan wrote: > __raise_softirq_irqoff will update per-CPU mask of pending softirqs, > it need to be called in irq disabled context in order to keep it atomic > operation, otherwise it will be interrupted by hardware interrupt, > and per-CPU softirqs

RE: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-12 Thread Jiafei Pan
...@infradead.org; mi...@kernel.org; t...@linutronix.de; rost...@goodmis.org; romain.per...@gmail.com; w...@kernel.org Cc: linux-kernel@vger.kernel.org; linux-rt-us...@vger.kernel.org; Jiafei Pan ; Leo Li ; Vladimir Oltean ; Jiafei Pan Subject: [PATCH] softirq: add irq off checking

[PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-05 Thread Jiafei Pan
__raise_softirq_irqoff will update per-CPU mask of pending softirqs, it need to be called in irq disabled context in order to keep it atomic operation, otherwise it will be interrupted by hardware interrupt, and per-CPU softirqs pending mask will be corrupted, the result is there will be