Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-22 Thread Huang Rui 
On Sun, Nov 22, 2015 at 10:54:08AM +0200, Denis Turischev wrote:
> Hi Rui,
> 
> On 11/20/2015 04:33 AM, Huang Rui wrote:
> > Hi Denis,
> > 
> > On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
> >> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> >> reuse the existent sp5100_tco driver.
> >>
> > 
> > Thank you to add this support!
> > Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
> > on AMD mullins but also on many other AMD platforms. Could you please
> > share some test method to me, that I am glad to do some quick tests. :)
> 
> My device is Compulabs's fitlet. It's a fanless mini PC, also known as 
> mintbox mini.
> http://fit-pc.com/wiki/index.php/Fit-PC_Product_Line:_fitlet
> Processor's datasheet:
> http://support.amd.com/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf
> 
> The dmesg output:
> sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05
> sp5100_tco: PCI Revision ID: 0x42
> sp5100_tco: Using 0xfeb0 for watchdog MMIO address
> sp5100_tco: Last reboot was not triggered by watchdog.
> sp5100_tco: initialized (0xc9702000). heartbeat=60 sec (nowayout=0)
> 

I verified it in my side. Thank you. :)
And found AMD new Carrizo platform also supported sp5100_tco watchdog.
I will send a patch to add support to KernCZ(Carrizo) chipset later.

Tested-by: Huang Rui 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-22 Thread Denis Turischev 
Hi Rui,

On 11/20/2015 04:33 AM, Huang Rui wrote:
> Hi Denis,
> 
> On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
>> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
>> reuse the existent sp5100_tco driver.
>>
> 
> Thank you to add this support!
> Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
> on AMD mullins but also on many other AMD platforms. Could you please
> share some test method to me, that I am glad to do some quick tests. :)

My device is Compulabs's fitlet. It's a fanless mini PC, also known as mintbox 
mini.
http://fit-pc.com/wiki/index.php/Fit-PC_Product_Line:_fitlet
Processor's datasheet:
http://support.amd.com/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf

The dmesg output:
sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05
sp5100_tco: PCI Revision ID: 0x42
sp5100_tco: Using 0xfeb0 for watchdog MMIO address
sp5100_tco: Last reboot was not triggered by watchdog.
sp5100_tco: initialized (0xc9702000). heartbeat=60 sec (nowayout=0)

Please let me know if you need any other info or tests to be performed.

Denis

> 
> Thanks,
> Rui
> 
>> Signed-off-by: Denis Turischev 
>>
>> diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
>> linux-4.3/drivers/watchdog/sp5100_tco.c
>> --- linux-4.3.orig/drivers/watchdog/sp5100_tco.c 2015-11-02 
>> 02:05:25.0 +0200
>> +++ linux-4.3/drivers/watchdog/sp5100_tco.c  2015-11-19 11:08:06.27218 
>> +0200
>> @@ -306,6 +306,8 @@
>>  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>>  { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>>PCI_ANY_ID, },
>> +{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
>> +  PCI_ANY_ID, },
>>  { 0, }, /* End of list */
>>  };
>>  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);   
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-22 Thread Huang Rui 
On Sun, Nov 22, 2015 at 10:54:08AM +0200, Denis Turischev wrote:
> Hi Rui,
> 
> On 11/20/2015 04:33 AM, Huang Rui wrote:
> > Hi Denis,
> > 
> > On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
> >> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> >> reuse the existent sp5100_tco driver.
> >>
> > 
> > Thank you to add this support!
> > Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
> > on AMD mullins but also on many other AMD platforms. Could you please
> > share some test method to me, that I am glad to do some quick tests. :)
> 
> My device is Compulabs's fitlet. It's a fanless mini PC, also known as 
> mintbox mini.
> http://fit-pc.com/wiki/index.php/Fit-PC_Product_Line:_fitlet
> Processor's datasheet:
> http://support.amd.com/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf
> 
> The dmesg output:
> sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05
> sp5100_tco: PCI Revision ID: 0x42
> sp5100_tco: Using 0xfeb0 for watchdog MMIO address
> sp5100_tco: Last reboot was not triggered by watchdog.
> sp5100_tco: initialized (0xc9702000). heartbeat=60 sec (nowayout=0)
> 

I verified it in my side. Thank you. :)
And found AMD new Carrizo platform also supported sp5100_tco watchdog.
I will send a patch to add support to KernCZ(Carrizo) chipset later.

Tested-by: Huang Rui 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-22 Thread Denis Turischev 
Hi Rui,

On 11/20/2015 04:33 AM, Huang Rui wrote:
> Hi Denis,
> 
> On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
>> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
>> reuse the existent sp5100_tco driver.
>>
> 
> Thank you to add this support!
> Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
> on AMD mullins but also on many other AMD platforms. Could you please
> share some test method to me, that I am glad to do some quick tests. :)

My device is Compulabs's fitlet. It's a fanless mini PC, also known as mintbox 
mini.
http://fit-pc.com/wiki/index.php/Fit-PC_Product_Line:_fitlet
Processor's datasheet:
http://support.amd.com/TechDocs/52740_16h_Models_30h-3Fh_BKDG.pdf

The dmesg output:
sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05
sp5100_tco: PCI Revision ID: 0x42
sp5100_tco: Using 0xfeb0 for watchdog MMIO address
sp5100_tco: Last reboot was not triggered by watchdog.
sp5100_tco: initialized (0xc9702000). heartbeat=60 sec (nowayout=0)

Please let me know if you need any other info or tests to be performed.

Denis

> 
> Thanks,
> Rui
> 
>> Signed-off-by: Denis Turischev 
>>
>> diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
>> linux-4.3/drivers/watchdog/sp5100_tco.c
>> --- linux-4.3.orig/drivers/watchdog/sp5100_tco.c 2015-11-02 
>> 02:05:25.0 +0200
>> +++ linux-4.3/drivers/watchdog/sp5100_tco.c  2015-11-19 11:08:06.27218 
>> +0200
>> @@ -306,6 +306,8 @@
>>  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>>  { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
>>PCI_ANY_ID, },
>> +{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
>> +  PCI_ANY_ID, },
>>  { 0, }, /* End of list */
>>  };
>>  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);   
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-19 Thread Huang Rui 
Hi Denis,

On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> reuse the existent sp5100_tco driver.
> 

Thank you to add this support!
Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
on AMD mullins but also on many other AMD platforms. Could you please
share some test method to me, that I am glad to do some quick tests. :)

Thanks,
Rui

> Signed-off-by: Denis Turischev 
> 
> diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
> linux-4.3/drivers/watchdog/sp5100_tco.c
> --- linux-4.3.orig/drivers/watchdog/sp5100_tco.c  2015-11-02 
> 02:05:25.0 +0200
> +++ linux-4.3/drivers/watchdog/sp5100_tco.c   2015-11-19 11:08:06.27218 
> +0200
> @@ -306,6 +306,8 @@
>  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
> PCI_ANY_ID, },
> + { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
> +   PCI_ANY_ID, },
>   { 0, }, /* End of list */
>  };
>  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-19 Thread Guenter Roeck 

On 11/19/2015 01:56 AM, Denis Turischev wrote:

AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

Signed-off-by: Denis Turischev 

diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
linux-4.3/drivers/watchdog/sp5100_tco.c
--- linux-4.3.orig/drivers/watchdog/sp5100_tco.c2015-11-02 
02:05:25.0 +0200
+++ linux-4.3/drivers/watchdog/sp5100_tco.c 2015-11-19 11:08:06.27218 
+0200
@@ -306,6 +306,8 @@
  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
  PCI_ANY_ID, },
+   { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+ PCI_ANY_ID, },
{ 0, }, /* End of list */
  };
  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl); 
--


Your patch does not apply to the latest kernel. Can you rebase to v4.4-rc1 and 
resubmit ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-19 Thread Denis Turischev 
AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

Signed-off-by: Denis Turischev 

diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
linux-4.3/drivers/watchdog/sp5100_tco.c
--- linux-4.3.orig/drivers/watchdog/sp5100_tco.c2015-11-02 
02:05:25.0 +0200
+++ linux-4.3/drivers/watchdog/sp5100_tco.c 2015-11-19 11:08:06.27218 
+0200
@@ -306,6 +306,8 @@
 static const struct pci_device_id sp5100_tco_pci_tbl[] = {
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
  PCI_ANY_ID, },
+   { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+ PCI_ANY_ID, },
{ 0, }, /* End of list */
 };
 MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-19 Thread Denis Turischev 
AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

Signed-off-by: Denis Turischev 

diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
linux-4.3/drivers/watchdog/sp5100_tco.c
--- linux-4.3.orig/drivers/watchdog/sp5100_tco.c2015-11-02 
02:05:25.0 +0200
+++ linux-4.3/drivers/watchdog/sp5100_tco.c 2015-11-19 11:08:06.27218 
+0200
@@ -306,6 +306,8 @@
 static const struct pci_device_id sp5100_tco_pci_tbl[] = {
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
  PCI_ANY_ID, },
+   { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+ PCI_ANY_ID, },
{ 0, }, /* End of list */
 };
 MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-19 Thread Huang Rui 
Hi Denis,

On Thu, Nov 19, 2015 at 05:56:00PM +0800, Denis Turischev wrote:
> AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
> reuse the existent sp5100_tco driver.
> 

Thank you to add this support!
Actually, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS is only the SMBus device id
on AMD mullins but also on many other AMD platforms. Could you please
share some test method to me, that I am glad to do some quick tests. :)

Thanks,
Rui

> Signed-off-by: Denis Turischev 
> 
> diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
> linux-4.3/drivers/watchdog/sp5100_tco.c
> --- linux-4.3.orig/drivers/watchdog/sp5100_tco.c  2015-11-02 
> 02:05:25.0 +0200
> +++ linux-4.3/drivers/watchdog/sp5100_tco.c   2015-11-19 11:08:06.27218 
> +0200
> @@ -306,6 +306,8 @@
>  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
>   { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
> PCI_ANY_ID, },
> + { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
> +   PCI_ANY_ID, },
>   { 0, }, /* End of list */
>  };
>  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] sp5100_tco: Add AMD Mullins platform support

2015-11-19 Thread Guenter Roeck 

On 11/19/2015 01:56 AM, Denis Turischev wrote:

AMD Mullins watchdog is fully compatible to the previous Hudson chipset,
reuse the existent sp5100_tco driver.

Signed-off-by: Denis Turischev 

diff -Nru linux-4.3.orig/drivers/watchdog/sp5100_tco.c 
linux-4.3/drivers/watchdog/sp5100_tco.c
--- linux-4.3.orig/drivers/watchdog/sp5100_tco.c2015-11-02 
02:05:25.0 +0200
+++ linux-4.3/drivers/watchdog/sp5100_tco.c 2015-11-19 11:08:06.27218 
+0200
@@ -306,6 +306,8 @@
  static const struct pci_device_id sp5100_tco_pci_tbl[] = {
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID,
  PCI_ANY_ID, },
+   { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, PCI_ANY_ID,
+ PCI_ANY_ID, },
{ 0, }, /* End of list */
  };
  MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl); 
--


Your patch does not apply to the latest kernel. Can you rebase to v4.4-rc1 and 
resubmit ?

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/