Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Julian Calaby
Hi Nitin, On Fri, Jun 23, 2017 at 12:37 AM, Nitin Gupta wrote: > Hi Julian, > > > On 6/22/17 3:53 AM, Julian Calaby wrote: >> >> On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta >> wrote: >>> >>> The function assumes that each PMD points to head

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Julian Calaby
Hi Nitin, On Fri, Jun 23, 2017 at 12:37 AM, Nitin Gupta wrote: > Hi Julian, > > > On 6/22/17 3:53 AM, Julian Calaby wrote: >> >> On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta >> wrote: >>> >>> The function assumes that each PMD points to head of a >>> huge page. This is not correct as a PMD can

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Nitin Gupta
Hi Julian, On 6/22/17 3:53 AM, Julian Calaby wrote: On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta wrote: The function assumes that each PMD points to head of a huge page. This is not correct as a PMD can point to start of any 8M region with a, say 256M, hugepage. The

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Nitin Gupta
Hi Julian, On 6/22/17 3:53 AM, Julian Calaby wrote: On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta wrote: The function assumes that each PMD points to head of a huge page. This is not correct as a PMD can point to start of any 8M region with a, say 256M, hugepage. The fix ensures that it

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Julian Calaby
Hi Nitin, On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta wrote: > The function assumes that each PMD points to head of a > huge page. This is not correct as a PMD can point to > start of any 8M region with a, say 256M, hugepage. The > fix ensures that it points to the

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Julian Calaby
Hi Nitin, On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta wrote: > The function assumes that each PMD points to head of a > huge page. This is not correct as a PMD can point to > start of any 8M region with a, say 256M, hugepage. The > fix ensures that it points to the correct head of any PMD >

[PATCH] sparc64: Fix gup_huge_pmd

2017-06-21 Thread Nitin Gupta
The function assumes that each PMD points to head of a huge page. This is not correct as a PMD can point to start of any 8M region with a, say 256M, hugepage. The fix ensures that it points to the correct head of any PMD huge page. Signed-off-by: Nitin Gupta ---

[PATCH] sparc64: Fix gup_huge_pmd

2017-06-21 Thread Nitin Gupta
The function assumes that each PMD points to head of a huge page. This is not correct as a PMD can point to start of any 8M region with a, say 256M, hugepage. The fix ensures that it points to the correct head of any PMD huge page. Signed-off-by: Nitin Gupta --- arch/sparc/mm/gup.c | 2 ++ 1