Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-11-04 Thread Mark Brown
On Thu, 29 Oct 2020 16:40:35 +0800, Qiang Zhao wrote: > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in > remove path"), this driver causes a kernel oops: > > [ 64.587431] Unable to handle kernel NULL pointer dereference at > virtual address 0020 > [..] > [

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-11-02 Thread Vladimir Oltean
On Mon, Nov 02, 2020 at 02:19:28AM +, Qiang Zhao wrote: > How about it looks like below: > > spi: fsl-dspi: fix wrong pointer in suspend/resume > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in > remove path"), this driver causes a "NULL pointer dereference" >

RE: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-11-01 Thread Qiang Zhao
On Thu, Oct 30, 2020 at 21:18PM +0800, Vladimir Oltean wrote: > -Original Message- > From: Vladimir Oltean > Sent: 2020年10月30日 21:18 > To: Qiang Zhao > Cc: broo...@kernel.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] sp

RE: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-11-01 Thread Qiang Zhao
On Thu, Oct 30, 2020 at 21:02PM, Mark Brown wrote: > -Original Message- > From: Mark Brown > Sent: 2020年10月30日 21:02 > To: Qiang Zhao > Cc: olte...@gmail.com; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] spi: fsl-dspi: fix NUL

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-10-30 Thread Vladimir Oltean
On Thu, Oct 29, 2020 at 04:40:35PM +0800, Qiang Zhao wrote: > From: Zhao Qiang > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in > remove path"), this driver causes a kernel oops: > > [ 64.587431] Unable to handle kernel NULL pointer dereference at > virtual address

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-10-30 Thread Vladimir Oltean
On Fri, Oct 30, 2020 at 02:04:06AM +, Qiang Zhao wrote: > I saw the patch, it just fix the issue when the kernel are booted up. > But there still have the issue when the driver suspend and resume. I see, sorry, I only paid attention to the commit message since it wasn't explicit that it is

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-10-30 Thread Mark Brown
On Thu, Oct 29, 2020 at 04:40:35PM +0800, Qiang Zhao wrote: > [ 64.587431] Unable to handle kernel NULL pointer dereference at > virtual address 0020 > [..] > [ 64.756080] Call trace: > [ 64.758526] dspi_suspend+0x30/0x78 > [ 64.762012] platform_pm_suspend+0x28/0x70 > [

RE: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-10-29 Thread Qiang Zhao
On Thu, Oct 29, 2020 at 19:03PM, Vladimir Oltean wrote: > -Original Message- > From: Vladimir Oltean > Sent: 2020年10月29日 19:03 > To: Qiang Zhao > Cc: broo...@kernel.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] spi: fsl-d

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-10-29 Thread Vladimir Oltean
On Thu, Oct 29, 2020 at 04:40:35PM +0800, Qiang Zhao wrote: > From: Zhao Qiang > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in > remove path"), this driver causes a kernel oops: > > [ 64.587431] Unable to handle kernel NULL pointer dereference at > virtual address

[PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-10-29 Thread Qiang Zhao
From: Zhao Qiang Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove path"), this driver causes a kernel oops: [ 64.587431] Unable to handle kernel NULL pointer dereference at virtual address 0020 [..] [ 64.756080] Call trace: [ 64.758526]

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-28 Thread Krzysztof Kozlowski
On Mon, Sep 28, 2020 at 09:46:22AM +0200, Michael Walle wrote: > Am 2020-09-28 09:29, schrieb Krzysztof Kozlowski: > > On Mon, 28 Sep 2020 at 01:28, Vladimir Oltean wrote: > > > > > > On Mon, Sep 28, 2020 at 12:43:36AM +0200, Michael Walle wrote: > > > > Since commit 530b5affc675 ("spi:

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-28 Thread Sascha Hauer
On Mon, Sep 28, 2020 at 02:27:47AM +0300, Vladimir Oltean wrote: > On Mon, Sep 28, 2020 at 12:43:36AM +0200, Michael Walle wrote: > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove > > path") this driver causes a kernel oops: > > > > [1.891065] Unable to handle kernel

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-28 Thread Michael Walle
Am 2020-09-28 09:29, schrieb Krzysztof Kozlowski: On Mon, 28 Sep 2020 at 01:28, Vladimir Oltean wrote: On Mon, Sep 28, 2020 at 12:43:36AM +0200, Michael Walle wrote: > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove > path") this driver causes a kernel oops: > > [

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-28 Thread Krzysztof Kozlowski
On Mon, 28 Sep 2020 at 09:29, Krzysztof Kozlowski wrote: > > > > > > This is because since this commit, the allocation of the drivers private > > > data is done explicitly and in this case spi_alloc_master() won't set the > > > correct pointer. > > > > > > Fixes: 530b5affc675 ("spi: fsl-dspi: fix

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-28 Thread Krzysztof Kozlowski
On Mon, 28 Sep 2020 at 01:28, Vladimir Oltean wrote: > > On Mon, Sep 28, 2020 at 12:43:36AM +0200, Michael Walle wrote: > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove > > path") this driver causes a kernel oops: > > > > [1.891065] Unable to handle kernel NULL

Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-27 Thread Vladimir Oltean
On Mon, Sep 28, 2020 at 12:43:36AM +0200, Michael Walle wrote: > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove > path") this driver causes a kernel oops: > > [1.891065] Unable to handle kernel NULL pointer dereference at virtual > address 0080 > [

[PATCH] spi: fsl-dspi: fix NULL pointer dereference

2020-09-27 Thread Michael Walle
Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove path") this driver causes a kernel oops: [1.891065] Unable to handle kernel NULL pointer dereference at virtual address 0080 [1.899889] Mem abort info: [1.902692] ESR = 0x9604 [1.905754]