Re: [PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Gustavo A. R. Silva
On 10/3/18 5:27 PM, Gustavo A. R. Silva wrote: > > > On 10/3/18 5:22 PM, Mark Brown wrote: >> On Wed, Oct 03, 2018 at 02:12:11PM +0200, Gustavo A. R. Silva wrote: >> >>> switch (drv_data->n_bytes) { >>> case 4: >>> bytes_left

Re: [PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Gustavo A. R. Silva
On 10/3/18 5:27 PM, Gustavo A. R. Silva wrote: > > > On 10/3/18 5:22 PM, Mark Brown wrote: >> On Wed, Oct 03, 2018 at 02:12:11PM +0200, Gustavo A. R. Silva wrote: >> >>> switch (drv_data->n_bytes) { >>> case 4: >>> bytes_left

Re: [PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Gustavo A. R. Silva
On 10/3/18 5:22 PM, Mark Brown wrote: > On Wed, Oct 03, 2018 at 02:12:11PM +0200, Gustavo A. R. Silva wrote: > >> switch (drv_data->n_bytes) { >> case 4: >> bytes_left >>= 1; >> +/* Fall through

Re: [PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Gustavo A. R. Silva
On 10/3/18 5:22 PM, Mark Brown wrote: > On Wed, Oct 03, 2018 at 02:12:11PM +0200, Gustavo A. R. Silva wrote: > >> switch (drv_data->n_bytes) { >> case 4: >> bytes_left >>= 1; >> +/* Fall through

Re: [PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Mark Brown
On Wed, Oct 03, 2018 at 02:12:11PM +0200, Gustavo A. R. Silva wrote: > switch (drv_data->n_bytes) { > case 4: > bytes_left >>= 1; > + /* Fall through */ > case 2: >

Re: [PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Mark Brown
On Wed, Oct 03, 2018 at 02:12:11PM +0200, Gustavo A. R. Silva wrote: > switch (drv_data->n_bytes) { > case 4: > bytes_left >>= 1; > + /* Fall through */ > case 2: >

[PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1056539 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/spi/spi-pxa2xx.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] spi: pxa2xx: Mark expected switch fall-through

2018-10-03 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1056539 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/spi/spi-pxa2xx.c | 1 + 1 file changed, 1 insertion(+) diff --git