Hi,
> Have you tested this?
I have finally set up a cuttlefish test env and tested both my first
patch set[0] and this patch (v2).
My first patch set works fine. I have nothing to say about it.
> Noticed any performance speedups or slow downs?
This patch doesn't work.
The boot process goes
> > + list_for_each_entry(it, >futex_wait_queue_list, list) {
> > + if (wait_queue->offset == arg->offset) {
> ^^
> You meant "it->offset".
Right, this is not good. Fixed in v2.
Thanks for the feedback!
regards,
Hugo
--
Hugo
On Thu, Feb 14, 2019 at 06:34:59PM +0100, Hugo Lefeuvre wrote:
> @@ -402,6 +410,7 @@ static int handle_vsoc_cond_wait(struct file *filp,
> struct vsoc_cond_wait *arg)
> struct vsoc_region_data *data = vsoc_dev.regions_data + region_number;
> int ret = 0;
> struct
> > Use multiple per-offset wait queues instead of one big wait queue per
> > region.
> >
> > Signed-off-by: Hugo Lefeuvre
>
> Have you tested this?
>
> Noticed any performance speedups or slow downs?
Not yet. I have started to set up a cuttlefish test environment but
it might take some time
On Thu, Feb 14, 2019 at 06:34:59PM +0100, Hugo Lefeuvre wrote:
> Use multiple per-offset wait queues instead of one big wait queue per
> region.
>
> Signed-off-by: Hugo Lefeuvre
Have you tested this?
Noticed any performance speedups or slow downs?
thanks,
greg k-h
Use multiple per-offset wait queues instead of one big wait queue per
region.
Signed-off-by: Hugo Lefeuvre
---
This patch is based on the simplify handle_vsoc_cond_wait patchset,
currently under review: https://lkml.org/lkml/2019/2/7/870
---
drivers/staging/android/TODO | 4 ---
6 matches
Mail list logo
