Re: [PATCH] staging: bcm: remove unnecessary else statement

2014-10-08 Thread Greg KH 
On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
> Removed the else statement occurring after an if statement with a
> return value as per checkpatch warning.
> 
> Signed-off-by: Karthik Nayak 
> ---
>  drivers/staging/bcm/InterfaceMisc.c | 9 -
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/bcm/InterfaceMisc.c 
> b/drivers/staging/bcm/InterfaceMisc.c
> index e5bcfec..1f31b8f 100644
> --- a/drivers/staging/bcm/InterfaceMisc.c
> +++ b/drivers/staging/bcm/InterfaceMisc.c
> @@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter 
> *psIntfAdapter,
>   DBG_LVL_ALL, "WRM failed status :%d", retval);
>   psIntfAdapter->psAdapter->DeviceAccess = false;
>   return retval;
> - } else {
> - psIntfAdapter->psAdapter->DeviceAccess = false;
> - BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> - DBG_LVL_ALL, "WRM sent %d", retval);
> - return STATUS_SUCCESS;
>   }
> + psIntfAdapter->psAdapter->DeviceAccess = false;
> + BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> + DBG_LVL_ALL, "WRM sent %d", retval);
> + return STATUS_SUCCESS;
>  }
>  
>  int BcmRDM(void *arg,
> -- 
> 2.1.0

This doesn't apply either, someone else must have done this change
already.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: bcm: remove unnecessary else statement

2014-10-08 Thread Greg KH 
On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
 Removed the else statement occurring after an if statement with a
 return value as per checkpatch warning.
 
 Signed-off-by: Karthik Nayak karthik@gmail.com
 ---
  drivers/staging/bcm/InterfaceMisc.c | 9 -
  1 file changed, 4 insertions(+), 5 deletions(-)
 
 diff --git a/drivers/staging/bcm/InterfaceMisc.c 
 b/drivers/staging/bcm/InterfaceMisc.c
 index e5bcfec..1f31b8f 100644
 --- a/drivers/staging/bcm/InterfaceMisc.c
 +++ b/drivers/staging/bcm/InterfaceMisc.c
 @@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter 
 *psIntfAdapter,
   DBG_LVL_ALL, WRM failed status :%d, retval);
   psIntfAdapter-psAdapter-DeviceAccess = false;
   return retval;
 - } else {
 - psIntfAdapter-psAdapter-DeviceAccess = false;
 - BCM_DEBUG_PRINT(psIntfAdapter-psAdapter, DBG_TYPE_OTHERS, WRM,
 - DBG_LVL_ALL, WRM sent %d, retval);
 - return STATUS_SUCCESS;
   }
 + psIntfAdapter-psAdapter-DeviceAccess = false;
 + BCM_DEBUG_PRINT(psIntfAdapter-psAdapter, DBG_TYPE_OTHERS, WRM,
 + DBG_LVL_ALL, WRM sent %d, retval);
 + return STATUS_SUCCESS;
  }
  
  int BcmRDM(void *arg,
 -- 
 2.1.0

This doesn't apply either, someone else must have done this change
already.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: bcm: remove unnecessary else statement

2014-09-30 Thread Karthik Nayak 
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.

Signed-off-by: Karthik Nayak 
---
 drivers/staging/bcm/InterfaceMisc.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/bcm/InterfaceMisc.c 
b/drivers/staging/bcm/InterfaceMisc.c
index e5bcfec..1f31b8f 100644
--- a/drivers/staging/bcm/InterfaceMisc.c
+++ b/drivers/staging/bcm/InterfaceMisc.c
@@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter 
*psIntfAdapter,
DBG_LVL_ALL, "WRM failed status :%d", retval);
psIntfAdapter->psAdapter->DeviceAccess = false;
return retval;
-   } else {
-   psIntfAdapter->psAdapter->DeviceAccess = false;
-   BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
-   DBG_LVL_ALL, "WRM sent %d", retval);
-   return STATUS_SUCCESS;
}
+   psIntfAdapter->psAdapter->DeviceAccess = false;
+   BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
+   DBG_LVL_ALL, "WRM sent %d", retval);
+   return STATUS_SUCCESS;
 }
 
 int BcmRDM(void *arg,
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: bcm: remove unnecessary else statement

2014-09-30 Thread Karthik Nayak 
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.

Signed-off-by: Karthik Nayak karthik@gmail.com
---
 drivers/staging/bcm/InterfaceMisc.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/bcm/InterfaceMisc.c 
b/drivers/staging/bcm/InterfaceMisc.c
index e5bcfec..1f31b8f 100644
--- a/drivers/staging/bcm/InterfaceMisc.c
+++ b/drivers/staging/bcm/InterfaceMisc.c
@@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter 
*psIntfAdapter,
DBG_LVL_ALL, WRM failed status :%d, retval);
psIntfAdapter-psAdapter-DeviceAccess = false;
return retval;
-   } else {
-   psIntfAdapter-psAdapter-DeviceAccess = false;
-   BCM_DEBUG_PRINT(psIntfAdapter-psAdapter, DBG_TYPE_OTHERS, WRM,
-   DBG_LVL_ALL, WRM sent %d, retval);
-   return STATUS_SUCCESS;
}
+   psIntfAdapter-psAdapter-DeviceAccess = false;
+   BCM_DEBUG_PRINT(psIntfAdapter-psAdapter, DBG_TYPE_OTHERS, WRM,
+   DBG_LVL_ALL, WRM sent %d, retval);
+   return STATUS_SUCCESS;
 }
 
 int BcmRDM(void *arg,
-- 
2.1.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/