Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

2014-08-31 Thread Chase Southwood
On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott wrote: > > That seems fine. Perhaps the variable 'p' in usbdux_ao_insn_write() should > also be of type '__le16 *'? > You're entirely correct. I had seen this in the output from Sparse, but for some reason at first glance I had convinced myself that t

Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

2014-08-30 Thread Ian Abbott
On 30/08/14 02:40, Chase Southwood wrote: Sparse has many warnings like: drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to restricted __le16 on lines on which devpriv->in_buf or devpriv->insn_buf are passed to le16_to_cpu(). This suggests that both of these variables should actu

[PATCH] staging: comedi: usbdux: fix sparse endianness warnings

2014-08-29 Thread Chase Southwood
Sparse has many warnings like: drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to restricted __le16 on lines on which devpriv->in_buf or devpriv->insn_buf are passed to le16_to_cpu(). This suggests that both of these variables should actually be of type __le16. Signed-off-by: Chas