Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Colin Ian King
On 16/08/17 14:37, Laurentiu Tudor wrote: > On 08/16/2017 03:06 PM, Dan Carpenter wrote: >> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The previous fix removed the equal to zero comparisons by the strcmps and >>> now the

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Colin Ian King
On 16/08/17 14:37, Laurentiu Tudor wrote: > On 08/16/2017 03:06 PM, Dan Carpenter wrote: >> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The previous fix removed the equal to zero comparisons by the strcmps and >>> now the function always returns

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Laurentiu Tudor
On 08/16/2017 03:06 PM, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The previous fix removed the equal to zero comparisons by the strcmps and >> now the function always returns true. Fix this by adding

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Laurentiu Tudor
On 08/16/2017 03:06 PM, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The previous fix removed the equal to zero comparisons by the strcmps and >> now the function always returns true. Fix this by adding in the missing >> logical

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 03:06:54PM +0300, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The previous fix removed the equal to zero comparisons by the strcmps and > > now the function always returns

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 03:06:54PM +0300, Dan Carpenter wrote: > On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The previous fix removed the equal to zero comparisons by the strcmps and > > now the function always returns true. Fix this by adding in

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > From: Colin Ian King > > The previous fix removed the equal to zero comparisons by the strcmps and > now the function always returns true. Fix this by adding in the missing > logical negation operators. > >

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Dan Carpenter
On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote: > From: Colin Ian King > > The previous fix removed the equal to zero comparisons by the strcmps and > now the function always returns true. Fix this by adding in the missing > logical negation operators. > > Detected by CoverityScan,

[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Colin King
From: Colin Ian King The previous fix removed the equal to zero comparisons by the strcmps and now the function always returns true. Fix this by adding in the missing logical negation operators. Detected by CoverityScan, CID#1452267 ("Constant expression result")

[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

2017-08-16 Thread Colin King
From: Colin Ian King The previous fix removed the equal to zero comparisons by the strcmps and now the function always returns true. Fix this by adding in the missing logical negation operators. Detected by CoverityScan, CID#1452267 ("Constant expression result") Fixes: b93ad9a067e1 ("staging: