Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Alan Cox
On Sun, 2014-08-31 at 13:02 -0700, Greg Kroah-Hartman wrote: > Adding Alan Cox, as he pushed this driver upstream... It's sort of a false positive. The existing code will work fine. Arguably all of this should be using the dma_ APIs. Alan -- To unsubscribe from this list: send the line

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Sudip Mukherjee
On Mon, Sep 01, 2014 at 12:35:14PM +0300, Dan Carpenter wrote: > On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: > > @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, > > char __user *buf, > >

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Dan Carpenter
On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: > @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, char > __user *buf, > AUDIO_READ_BUFFER_AVAILABLE); > > /* copy data to user space */ > -

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Dan Carpenter
On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, char __user *buf, AUDIO_READ_BUFFER_AVAILABLE); /* copy data to user space */ -

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Sudip Mukherjee
On Mon, Sep 01, 2014 at 12:35:14PM +0300, Dan Carpenter wrote: On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: @@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp, char __user *buf,

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-09-01 Thread Alan Cox
On Sun, 2014-08-31 at 13:02 -0700, Greg Kroah-Hartman wrote: Adding Alan Cox, as he pushed this driver upstream... It's sort of a false positive. The existing code will work fine. Arguably all of this should be using the dma_ APIs. Alan -- To unsubscribe from this list: send the line

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-08-31 Thread Greg Kroah-Hartman
Adding Alan Cox, as he pushed this driver upstream... On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: > fixed sparse warning of incorrect type in argument 1 and incorrect type in > argument 2 > it was directly dereferencing a __iomem pointer , which will work in x86 but > will

[PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-08-31 Thread Sudip Mukherjee
fixed sparse warning of incorrect type in argument 1 and incorrect type in argument 2 it was directly dereferencing a __iomem pointer , which will work in x86 but will fail in other architectures. Signed-off-by: Sudip Mukherjee --- hi, can you please reveiew the patch and check if the

[PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-08-31 Thread Sudip Mukherjee
fixed sparse warning of incorrect type in argument 1 and incorrect type in argument 2 it was directly dereferencing a __iomem pointer , which will work in x86 but will fail in other architectures. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- hi, can you please reveiew the patch and

Re: [PATCH] staging: goldfish_audio.c: sparse warning of incorrect type

2014-08-31 Thread Greg Kroah-Hartman
Adding Alan Cox, as he pushed this driver upstream... On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote: fixed sparse warning of incorrect type in argument 1 and incorrect type in argument 2 it was directly dereferencing a __iomem pointer , which will work in x86 but will fail