Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-14 Thread Joe Perches
On Wed, 2021-04-14 at 09:35 -0500, Alex Elder wrote: > On 4/14/21 9:29 AM, Joe Perches wrote: > > On Wed, 2021-04-14 at 08:17 -0500, Alex Elder wrote: > > > Perhaps (like the -W options for GCC) there > > > could be a way to specify in a Makefile which checkpatch > > > messages are reported/not

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-14 Thread Alex Elder
On 4/14/21 9:29 AM, Joe Perches wrote: On Wed, 2021-04-14 at 08:17 -0500, Alex Elder wrote: Perhaps (like the -W options for GCC) there could be a way to specify in a Makefile which checkpatch messages are reported/not reported? I don't claim that's a good suggestion, but if I could optionally

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-14 Thread Joe Perches
On Wed, 2021-04-14 at 08:17 -0500, Alex Elder wrote: > Perhaps (like the -W options for GCC) there > could be a way to specify in a Makefile which checkpatch > messages are reported/not reported? I don't claim that's > a good suggestion, but if I could optionally indicate > somewhere that "two

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-14 Thread Alex Elder
On 4/6/21 12:21 PM, Joe Perches wrote: On Tue, 2021-04-06 at 15:27 +0200, Greg KH wrote: On Tue, Apr 06, 2021 at 06:42:59PM +0600, Zhansaya Bagdauletkyzy wrote: Match next line with open parentheses by adding tabs/spaces to conform with Linux kernel coding style. Reported by checkpatch. []

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-06 Thread Joe Perches
On Tue, 2021-04-06 at 15:27 +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 06:42:59PM +0600, Zhansaya Bagdauletkyzy wrote: > > Match next line with open parentheses by adding tabs/spaces > > to conform with Linux kernel coding style. > > Reported by checkpatch. [] > > diff --git

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 06:42:59PM +0600, Zhansaya Bagdauletkyzy wrote: > Match next line with open parentheses by adding tabs/spaces > to conform with Linux kernel coding style. > Reported by checkpatch. > > Signed-off-by: Zhansaya Bagdauletkyzy > --- > drivers/staging/greybus/camera.c | 10

[PATCH] staging: greybus: Match parentheses alignment

2021-04-06 Thread Zhansaya Bagdauletkyzy
Match next line with open parentheses by adding tabs/spaces to conform with Linux kernel coding style. Reported by checkpatch. Signed-off-by: Zhansaya Bagdauletkyzy --- drivers/staging/greybus/camera.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git