Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Lars-Peter Clausen
On 10/25/2018 04:55 PM, Himanshu Jha wrote: > On Thu, Oct 25, 2018 at 11:26:36AM -0300, Renato Lui Geh wrote: >> Hi, >> >> Thanks for the quick review. :) >> >>> But please create one patch per issue and do not put unrelated changes into >>> the same patch. >> >> Should I resend this patch as a

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Lars-Peter Clausen
On 10/25/2018 04:55 PM, Himanshu Jha wrote: > On Thu, Oct 25, 2018 at 11:26:36AM -0300, Renato Lui Geh wrote: >> Hi, >> >> Thanks for the quick review. :) >> >>> But please create one patch per issue and do not put unrelated changes into >>> the same patch. >> >> Should I resend this patch as a

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Himanshu Jha
On Thu, Oct 25, 2018 at 11:26:36AM -0300, Renato Lui Geh wrote: > Hi, > > Thanks for the quick review. :) > > > But please create one patch per issue and do not put unrelated changes into > > the same patch. > > Should I resend this patch as a patchset containing the two changes? Yes! "One

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Himanshu Jha
On Thu, Oct 25, 2018 at 11:26:36AM -0300, Renato Lui Geh wrote: > Hi, > > Thanks for the quick review. :) > > > But please create one patch per issue and do not put unrelated changes into > > the same patch. > > Should I resend this patch as a patchset containing the two changes? Yes! "One

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Renato Lui Geh
Hi, Thanks for the quick review. :) But please create one patch per issue and do not put unrelated changes into the same patch. Should I resend this patch as a patchset containing the two changes? Also your mail client seems to have replaced tabs in the patch with spaces, this means the

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Renato Lui Geh
Hi, Thanks for the quick review. :) But please create one patch per issue and do not put unrelated changes into the same patch. Should I resend this patch as a patchset containing the two changes? Also your mail client seems to have replaced tabs in the patch with spaces, this means the

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Lars-Peter Clausen
On 10/25/2018 03:32 PM, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output. > This patch fixes two issues. > > - The driver read an outdated value set at initialization. It now > updates its voltage on read. > - Variable val subtracted an uninitialized

Re: [PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Lars-Peter Clausen
On 10/25/2018 03:32 PM, Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output. > This patch fixes two issues. > > - The driver read an outdated value set at initialization. It now > updates its voltage on read. > - Variable val subtracted an uninitialized

[PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Renato Lui Geh
The ad7780 driver previously did not read the correct device output. This patch fixes two issues. - The driver read an outdated value set at initialization. It now updates its voltage on read. - Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. This was fixed by assiging

[PATCH] staging: iio: ad7780: update voltage on read

2018-10-25 Thread Renato Lui Geh
The ad7780 driver previously did not read the correct device output. This patch fixes two issues. - The driver read an outdated value set at initialization. It now updates its voltage on read. - Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. This was fixed by assiging