Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-16 Thread Bharath Vedartham
On Mon, Jul 15, 2019 at 03:01:43PM -0700, John Hubbard wrote: > On 7/15/19 2:47 PM, Matt Sickler wrote: > > It looks like Outlook is going to absolutely trash this email. Hopefully > > it comes through okay. > > > ... > >> > >> Because this is a common pattern, and because the code here doesn't

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread John Hubbard
On 7/15/19 3:01 PM, John Hubbard wrote: > On 7/15/19 2:47 PM, Matt Sickler wrote: ... > I agree: the PageReserved check looks unnecessary here, from my > outside-the-kpc_2000-team > perspective, anyway. Assuming that your analysis above is correct, you could > collapse that > whole think into

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread John Hubbard
On 7/15/19 2:47 PM, Matt Sickler wrote: > It looks like Outlook is going to absolutely trash this email. Hopefully it > comes through okay. > ... >> >> Because this is a common pattern, and because the code here doesn't likely >> need to set page dirty before the dma_unmap_sg call, I think the

RE: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread Matt Sickler
It looks like Outlook is going to absolutely trash this email. Hopefully it comes through okay. >> There have been issues with get_user_pages and filesystem writeback. >> The issues are better described in [1]. >> >> The solution being proposed wants to keep track of gup_pinned pages >which

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread Bharath Vedartham
On Mon, Jul 15, 2019 at 01:14:13PM -0700, John Hubbard wrote: > On 7/15/19 12:52 PM, Bharath Vedartham wrote: > > There have been issues with get_user_pages and filesystem writeback. > > The issues are better described in [1]. > > > > The solution being proposed wants to keep track of gup_pinned

Re: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread John Hubbard
On 7/15/19 12:52 PM, Bharath Vedartham wrote: > There have been issues with get_user_pages and filesystem writeback. > The issues are better described in [1]. > > The solution being proposed wants to keep track of gup_pinned pages which > will allow to take furthur steps to coordinate between

[PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread Bharath Vedartham
There have been issues with get_user_pages and filesystem writeback. The issues are better described in [1]. The solution being proposed wants to keep track of gup_pinned pages which will allow to take furthur steps to coordinate between subsystems using gup. put_user_page() simply calls