Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread Dan Carpenter
On Tue, Jun 09, 2020 at 01:03:51AM +0530, Souptick Joarder wrote: > On Tue, Jun 9, 2020 at 12:47 AM Dan Carpenter > wrote: > > > > On Tue, Jun 09, 2020 at 12:31:42AM +0530, Souptick Joarder wrote: > > > > > @@ -189,10 +192,9 @@ static int kpc_dma_transfer(struct > > > > > dev_private_data

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread Souptick Joarder
On Tue, Jun 9, 2020 at 12:47 AM Dan Carpenter wrote: > > On Tue, Jun 09, 2020 at 12:31:42AM +0530, Souptick Joarder wrote: > > > > @@ -189,10 +192,9 @@ static int kpc_dma_transfer(struct > > > > dev_private_data *priv, > > > > sg_free_table(>sgt); > > > >err_dma_map_sg: > > > >

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread John Hubbard
On 2020-06-08 12:16, Dan Carpenter wrote: On Mon, Jun 08, 2020 at 12:05:57PM -0700, John Hubbard wrote: On 2020-06-08 12:01, Souptick Joarder wrote: On Mon, Jun 1, 2020 at 7:15 AM John Hubbard wrote: On 2020-05-31 10:51, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread Dan Carpenter
On Tue, Jun 09, 2020 at 12:31:42AM +0530, Souptick Joarder wrote: > > > @@ -189,10 +192,9 @@ static int kpc_dma_transfer(struct dev_private_data > > > *priv, > > > sg_free_table(>sgt); > > >err_dma_map_sg: > > >err_alloc_sg_table: > > > > So now we end up with two unnecessary

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread Dan Carpenter
On Mon, Jun 08, 2020 at 12:05:57PM -0700, John Hubbard wrote: > On 2020-06-08 12:01, Souptick Joarder wrote: > > On Mon, Jun 1, 2020 at 7:15 AM John Hubbard wrote: > > > > > > On 2020-05-31 10:51, Souptick Joarder wrote: > > > > In 2019, we introduced pin_user_pages*() and now we are converting

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread John Hubbard
On 2020-06-08 12:01, Souptick Joarder wrote: On Mon, Jun 1, 2020 at 7:15 AM John Hubbard wrote: On 2020-05-31 10:51, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread Souptick Joarder
On Mon, Jun 1, 2020 at 7:15 AM John Hubbard wrote: > > On 2020-05-31 10:51, Souptick Joarder wrote: > > In 2019, we introduced pin_user_pages*() and now we are converting > > get_user_pages*() to the new API as appropriate. [1] & [2] could > > be referred for more information. > > > > When

Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-05-31 Thread John Hubbard
On 2020-05-31 10:51, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. When pin_user_pages() returns numbers of partially mapped pages, those pages were

[PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages()

2020-05-31 Thread Souptick Joarder
In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. When pin_user_pages() returns numbers of partially mapped pages, those pages were not unpinned as part of error handling. Fixed it