Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 16, 2018 at 06:02:07PM +, Eremin, Dmitry wrote: > The logic of the original commit 4d99b2581eff ("staging: lustre: avoid > intensive reconnecting for ko2iblnd") > was assumed conditional free of struct kib_conn if the second argument > free_conn in function >

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 16, 2018 at 06:02:07PM +, Eremin, Dmitry wrote: > The logic of the original commit 4d99b2581eff ("staging: lustre: avoid > intensive reconnecting for ko2iblnd") > was assumed conditional free of struct kib_conn if the second argument > free_conn in function >

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-17 Thread Greg Kroah-Hartman
On Wed, Jan 17, 2018 at 12:36:19AM +, Dilger, Andreas wrote: > > > On Jan 16, 2018, at 09:56, Greg Kroah-Hartman > > wrote: > > > > On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: > >> In the original commit

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-17 Thread Greg Kroah-Hartman
On Wed, Jan 17, 2018 at 12:36:19AM +, Dilger, Andreas wrote: > > > On Jan 16, 2018, at 09:56, Greg Kroah-Hartman > > wrote: > > > > On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: > >> In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 > > > > Please use the

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Dilger, Andreas
> On Jan 16, 2018, at 09:56, Greg Kroah-Hartman > wrote: > > On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: >> In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 > > Please use the documented way to write this: > 4d99b2581eff

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Dilger, Andreas
> On Jan 16, 2018, at 09:56, Greg Kroah-Hartman > wrote: > > On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: >> In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 > > Please use the documented way to write this: > 4d99b2581eff ("staging: lustre: avoid

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Eremin, Dmitry
The logic of the original commit 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") was assumed conditional free of struct kib_conn if the second argument free_conn in function kiblnd_destroy_conn(struct kib_conn *conn, bool free_conn) is true. But this hunk of code was

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Eremin, Dmitry
The logic of the original commit 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") was assumed conditional free of struct kib_conn if the second argument free_conn in function kiblnd_destroy_conn(struct kib_conn *conn, bool free_conn) is true. But this hunk of code was

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Greg Kroah-Hartman
On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: > In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 Please use the documented way to write this: 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") > was missed one hunk. Added it now

Re: [PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Greg Kroah-Hartman
On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote: > In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 Please use the documented way to write this: 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for ko2iblnd") > was missed one hunk. Added it now

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Eremin, Dmitry
In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 was missed one hunk. Added it now to avoid issue with use after free. Signed-off-by: Dmitry Eremin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] staging: lustre: Fix avoid intensive reconnecting for ko2iblnd patch

2018-01-16 Thread Eremin, Dmitry
In the original commit 4d99b2581effe115376402e710fbcb1c3c073769 was missed one hunk. Added it now to avoid issue with use after free. Signed-off-by: Dmitry Eremin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git