Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Andy Walls
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote: > On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > > > > > - if (ir == NULL) { > > > > - dev_err(ir->l.dev, "close: no private_data attached to > > > > the file > !\n"); > > > commit

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Rickard Strandqvist
2015-01-30 14:09 GMT+01:00 : > On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > >> > > - if (ir == NULL) { >> > > - dev_err(ir->l.dev, "close: no private_data attached to the file > !\n"); >> > >> > Yes, the dev_err() call is an obvious thinko. >> > >> > However, I'm not sure

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Valdis . Kletnieks
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > > > - if (ir == NULL) { > > > - dev_err(ir->l.dev, "close: no private_data attached to the file !\n"); > > > > Yes, the dev_err() call is an obvious thinko. > > > > However, I'm not sure whether removing it entirely is right

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Dan Carpenter
On Thu, Jan 29, 2015 at 05:12:40PM -0500, valdis.kletni...@vt.edu wrote: > On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: > > Fix a possible null pointer dereference, there is > > otherwise a risk of a possible null pointer dereference. > > > > This was found using a static code

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Rickard Strandqvist
2015-01-30 14:09 GMT+01:00 valdis.kletni...@vt.edu: On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: - if (ir == NULL) { - dev_err(ir-l.dev, close: no private_data attached to the file !\n); Yes, the dev_err() call is an obvious thinko. However, I'm not sure

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Andy Walls
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote: On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: - if (ir == NULL) { - dev_err(ir-l.dev, close: no private_data attached to the file !\n); commit

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Dan Carpenter
On Thu, Jan 29, 2015 at 05:12:40PM -0500, valdis.kletni...@vt.edu wrote: On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Valdis . Kletnieks
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: - if (ir == NULL) { - dev_err(ir-l.dev, close: no private_data attached to the file !\n); Yes, the dev_err() call is an obvious thinko. However, I'm not sure whether removing it entirely is right either. If there

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Valdis . Kletnieks
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: > Fix a possible null pointer dereference, there is > otherwise a risk of a possible null pointer dereference. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- >

[PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/media/lirc/lirc_zilog.c |4 +--- 1 file changed, 1

[PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Rickard Strandqvist
Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/media/lirc/lirc_zilog.c |

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-29 Thread Valdis . Kletnieks
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: Fix a possible null pointer dereference, there is otherwise a risk of a possible null pointer dereference. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist