Re: [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
On Sat, Aug 11, 2018 at 06:15:05PM +0200, Michael Anckaert wrote: > This patch fixes some issues with missing SPDX-License-Identifier > comments. > > Disclaimer: this is my first patch and instructions were taken from the > KernelNewbies project. This does not belong in a changelog comment. If you want to put info like this, put it below the --- line. > > Signed-off-by: Michael Anckaert > --- > drivers/staging/netlogic/Kconfig| 6 +++--- > drivers/staging/netlogic/platform_net.c | 1 + > drivers/staging/netlogic/platform_net.h | 1 + > drivers/staging/netlogic/xlr_net.c | 1 + > drivers/staging/netlogic/xlr_net.h | 1 + > 5 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/netlogic/Kconfig > b/drivers/staging/netlogic/Kconfig > index d660de51b541..ab0b756bc08b 100644 > --- a/drivers/staging/netlogic/Kconfig > +++ b/drivers/staging/netlogic/Kconfig > @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET > tristate "Netlogic XLR/XLS network device" > depends on CPU_XLR > select PHYLIB > - ---help--- > - This driver support Netlogic XLR/XLS on chip gigabit > - Ethernet. > + help > + This driver support Netlogic XLR/XLS on chip gigabit > + Ethernet. This change has nothing to do with spdx identifiers :( Please fix up and resend as 2 different patches. thanks, greg k-h
Re: [PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
On Sat, Aug 11, 2018 at 06:15:05PM +0200, Michael Anckaert wrote: > This patch fixes some issues with missing SPDX-License-Identifier > comments. > > Disclaimer: this is my first patch and instructions were taken from the > KernelNewbies project. This does not belong in a changelog comment. If you want to put info like this, put it below the --- line. > > Signed-off-by: Michael Anckaert > --- > drivers/staging/netlogic/Kconfig| 6 +++--- > drivers/staging/netlogic/platform_net.c | 1 + > drivers/staging/netlogic/platform_net.h | 1 + > drivers/staging/netlogic/xlr_net.c | 1 + > drivers/staging/netlogic/xlr_net.h | 1 + > 5 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/netlogic/Kconfig > b/drivers/staging/netlogic/Kconfig > index d660de51b541..ab0b756bc08b 100644 > --- a/drivers/staging/netlogic/Kconfig > +++ b/drivers/staging/netlogic/Kconfig > @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET > tristate "Netlogic XLR/XLS network device" > depends on CPU_XLR > select PHYLIB > - ---help--- > - This driver support Netlogic XLR/XLS on chip gigabit > - Ethernet. > + help > + This driver support Netlogic XLR/XLS on chip gigabit > + Ethernet. This change has nothing to do with spdx identifiers :( Please fix up and resend as 2 different patches. thanks, greg k-h
[PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
This patch fixes some issues with missing SPDX-License-Identifier comments. Disclaimer: this is my first patch and instructions were taken from the KernelNewbies project. Signed-off-by: Michael Anckaert --- drivers/staging/netlogic/Kconfig| 6 +++--- drivers/staging/netlogic/platform_net.c | 1 + drivers/staging/netlogic/platform_net.h | 1 + drivers/staging/netlogic/xlr_net.c | 1 + drivers/staging/netlogic/xlr_net.h | 1 + 5 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig index d660de51b541..ab0b756bc08b 100644 --- a/drivers/staging/netlogic/Kconfig +++ b/drivers/staging/netlogic/Kconfig @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET tristate "Netlogic XLR/XLS network device" depends on CPU_XLR select PHYLIB - ---help--- - This driver support Netlogic XLR/XLS on chip gigabit - Ethernet. + help + This driver support Netlogic XLR/XLS on chip gigabit + Ethernet. diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c index abf4c71ee66b..3886c99c1f68 100644 --- a/drivers/staging/netlogic/platform_net.c +++ b/drivers/staging/netlogic/platform_net.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved diff --git a/drivers/staging/netlogic/platform_net.h b/drivers/staging/netlogic/platform_net.h index e1b27f649590..1d994f0d0995 100644 --- a/drivers/staging/netlogic/platform_net.h +++ b/drivers/staging/netlogic/platform_net.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index e461168313bf..201db10692de 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/staging/netlogic/xlr_net.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h index f76e16cfd15d..de51d64c1f23 100644 --- a/drivers/staging/netlogic/xlr_net.h +++ b/drivers/staging/netlogic/xlr_net.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved -- 2.17.1
[PATCH] staging: netlogic: Fixed comments to include SPDX-License-Identifier
This patch fixes some issues with missing SPDX-License-Identifier comments. Disclaimer: this is my first patch and instructions were taken from the KernelNewbies project. Signed-off-by: Michael Anckaert --- drivers/staging/netlogic/Kconfig| 6 +++--- drivers/staging/netlogic/platform_net.c | 1 + drivers/staging/netlogic/platform_net.h | 1 + drivers/staging/netlogic/xlr_net.c | 1 + drivers/staging/netlogic/xlr_net.h | 1 + 5 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/Kconfig b/drivers/staging/netlogic/Kconfig index d660de51b541..ab0b756bc08b 100644 --- a/drivers/staging/netlogic/Kconfig +++ b/drivers/staging/netlogic/Kconfig @@ -2,6 +2,6 @@ config NETLOGIC_XLR_NET tristate "Netlogic XLR/XLS network device" depends on CPU_XLR select PHYLIB - ---help--- - This driver support Netlogic XLR/XLS on chip gigabit - Ethernet. + help + This driver support Netlogic XLR/XLS on chip gigabit + Ethernet. diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c index abf4c71ee66b..3886c99c1f68 100644 --- a/drivers/staging/netlogic/platform_net.c +++ b/drivers/staging/netlogic/platform_net.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved diff --git a/drivers/staging/netlogic/platform_net.h b/drivers/staging/netlogic/platform_net.h index e1b27f649590..1d994f0d0995 100644 --- a/drivers/staging/netlogic/platform_net.h +++ b/drivers/staging/netlogic/platform_net.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index e461168313bf..201db10692de 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/staging/netlogic/xlr_net.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/staging/netlogic/xlr_net.h index f76e16cfd15d..de51d64c1f23 100644 --- a/drivers/staging/netlogic/xlr_net.h +++ b/drivers/staging/netlogic/xlr_net.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2003-2012 Broadcom Corporation * All Rights Reserved -- 2.17.1
