Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Joe Perches
On Wed, 2013-06-26 at 13:46 -0400, Jason Baron wrote: > echo "grouping control_var level N +p" > /debugfs/dynamic_debug/control > > or > > echo "grouping control_var mask 0xN +p" > /debugfs/dynamic_debug/control > > So we can think of the 'control_var' as 'grouping' debug statements > together.

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 02:03 PM, Joe Perches wrote: > (Using Jason Baron's most current email address) > > On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote: >> On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: >>> On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: a long needed extension

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 01:29 PM, Joe Perches wrote: > On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: >> On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: >>> convert all debug messages from printk to dev_dbg() & add kernel config to >>> enable/disable these messages during compilation. >> No

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Joe Perches
(Using Jason Baron's most current email address) On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote: > On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: > > On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: > > > a long needed extension to dev_dbg is to enable classes > > > of message

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Alan Stern
On Tue, 25 Jun 2013, Rupesh Gujare wrote: > On 25/06/13 18:02, Greg KH wrote: > > On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: > >> convert all debug messages from printk to dev_dbg() & add kernel config to > >> enable/disable these messages during compilation. > > No, just use t

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Greg KH
On Tue, Jun 25, 2013 at 06:49:12PM +0100, Rupesh Gujare wrote: > On 25/06/13 18:02, Greg KH wrote: > >On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: > >>convert all debug messages from printk to dev_dbg() & add kernel config to > >>enable/disable these messages during compilation. >

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Joe Perches
On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: > On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: > > a long needed extension to dev_dbg is to enable classes > > of messages by level or mask. > > > > There are many existing macros like > > > > #define module_dbg(level, fmt, ...) >

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Rupesh Gujare
On 25/06/13 18:02, Greg KH wrote: On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: convert all debug messages from printk to dev_dbg() & add kernel config to enable/disable these messages during compilation. No, just use the built-in dynamic debug code in the kernel, no need to pr

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Greg KH
On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: > On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: > > On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: > > > convert all debug messages from printk to dev_dbg() & add kernel config to > > > enable/disable these messages du

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Joe Perches
On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: > On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: > > convert all debug messages from printk to dev_dbg() & add kernel config to > > enable/disable these messages during compilation. > No, just use the built-in dynamic debug code in

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Greg KH
On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: > convert all debug messages from printk to dev_dbg() & add kernel config to > enable/disable these messages during compilation. No, just use the built-in dynamic debug code in the kernel, no need to provide any new macros or functions

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Joe Perches
On Tue, 2013-06-25 at 17:30 +0100, Rupesh Gujare wrote: > convert all debug messages from printk to dev_dbg() & add kernel config to > enable/disable these messages during compilation. [] > -#define oz_trace(...) printk(TRACE_PREFIX __VA_ARGS__) > +#define oz_trace(fmt, ...) dev_dbg(g_oz_wpan_dev,

[PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-25 Thread Rupesh Gujare
convert all debug messages from printk to dev_dbg() & add kernel config to enable/disable these messages during compilation. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/Kbuild|2 +- drivers/staging/ozwpan/Kconfig |9 + drivers/staging/ozwpan/ozcdev.c |9 +++