Re: [PATCH] staging: qlge: remove else after break

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 06:11:43AM +0530, Mitali Borkar wrote: > linux-staging@lists,linux-kernel@vger.kernel.org > Bcc: > Subject: [PATCH] staging: qlge:remove else after break > Reply-To: Very odd, why is this in the body of the email? > > Fixed Warning:- else is not needed after break >

Re: [Outreachy kernel] [PATCH] staging: qlge: remove else after break

2021-04-04 Thread Matthew Wilcox
On Mon, Apr 05, 2021 at 06:11:43AM +0530, Mitali Borkar wrote: > - } else { > - netif_err(qdev, drv, qdev->ndev, > + } netif_err(qdev, drv, qdev->ndev, That's not the normal indentation style ... does checkpatch really not complain about that? >

[PATCH] staging: qlge: remove else after break

2021-04-04 Thread Mitali Borkar
linux-staging@lists,linux-kernel@vger.kernel.org Bcc: Subject: [PATCH] staging: qlge:remove else after break Reply-To: Fixed Warning:- else is not needed after break break terminates the loop if encountered. else is unnecessary and increases indenatation Signed-off-by: Mitali Borkar ---