Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2019-01-10 Thread Nick Desaulniers
On Wed, Jan 9, 2019 at 11:01 PM Greg KH wrote: > > On Wed, Jan 09, 2019 at 04:19:30PM -0800, Nick Desaulniers wrote: > > Digging up an old thread to point out I was wrong: > > > > On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers > > wrote: > > > > This is not a million-little-commits problem;

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2019-01-09 Thread Greg KH
On Wed, Jan 09, 2019 at 04:19:30PM -0800, Nick Desaulniers wrote: > Digging up an old thread to point out I was wrong: > > On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers > wrote: > > > This is not a million-little-commits problem; more like 2 drivers in > > > the whole tree have this problem.

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2019-01-09 Thread Nick Desaulniers
Digging up an old thread to point out I was wrong: On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers wrote: > > This is not a million-little-commits problem; more like 2 drivers in > > the whole tree have this problem. > > > > Note that this change that Nathan has DOES NOT need to applied to > >

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-27 Thread Nick Desaulniers
On Thu, Sep 27, 2018 at 1:05 PM Nick Desaulniers wrote: > > On Wed, Sep 26, 2018 at 10:16 PM Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > > > Clang emits the following warning: > > > > > >

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-27 Thread Nick Desaulniers
On Thu, Sep 27, 2018 at 1:05 PM Nick Desaulniers wrote: > > On Wed, Sep 26, 2018 at 10:16 PM Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > > > Clang emits the following warning: > > > > > >

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-27 Thread Nick Desaulniers
On Wed, Sep 26, 2018 at 10:16 PM Greg Kroah-Hartman wrote: > > On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > > Clang emits the following warning: > > > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > > 'acpi_ids' is not needed and will not be

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-27 Thread Nick Desaulniers
On Wed, Sep 26, 2018 at 10:16 PM Greg Kroah-Hartman wrote: > > On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > > Clang emits the following warning: > > > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > > 'acpi_ids' is not needed and will not be

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-26 Thread Greg Kroah-Hartman
On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > Clang emits the following warning: > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > 'acpi_ids' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-26 Thread Greg Kroah-Hartman
On Wed, Sep 26, 2018 at 04:20:55PM -0700, Nathan Chancellor wrote: > Clang emits the following warning: > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable > 'acpi_ids' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct

[PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-26 Thread Nathan Chancellor
Clang emits the following warning: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable 'acpi_ids' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct acpi_device_id acpi_ids[] = { ^ 1 warning generated.

[PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2018-09-26 Thread Nathan Chancellor
Clang emits the following warning: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable 'acpi_ids' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct acpi_device_id acpi_ids[] = { ^ 1 warning generated.