Re: [PATCH] staging: rtl8723bs: remove memset before memcpy

2017-08-28 Thread Himanshu Jha
On Mon, Aug 28, 2017 at 09:19:06AM +0300, Dan Carpenter wrote: > On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote: > > calling memcpy immediately after memset with the same region of memory > > makes memset redundant. > > > > Build successfully. > > > > Thanks for the patch, it

Re: [PATCH] staging: rtl8723bs: remove memset before memcpy

2017-08-28 Thread Himanshu Jha
On Mon, Aug 28, 2017 at 09:19:06AM +0300, Dan Carpenter wrote: > On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote: > > calling memcpy immediately after memset with the same region of memory > > makes memset redundant. > > > > Build successfully. > > > > Thanks for the patch, it

Re: [PATCH] staging: rtl8723bs: remove memset before memcpy

2017-08-28 Thread Dan Carpenter
On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Build successfully. > Thanks for the patch, it looks good. You don't need to say that it builds successfully, because we already

Re: [PATCH] staging: rtl8723bs: remove memset before memcpy

2017-08-28 Thread Dan Carpenter
On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Build successfully. > Thanks for the patch, it looks good. You don't need to say that it builds successfully, because we already

[PATCH] staging: rtl8723bs: remove memset before memcpy

2017-08-27 Thread Himanshu Jha
calling memcpy immediately after memset with the same region of memory makes memset redundant. Build successfully. Signed-off-by: Himanshu Jha --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 --

[PATCH] staging: rtl8723bs: remove memset before memcpy

2017-08-27 Thread Himanshu Jha
calling memcpy immediately after memset with the same region of memory makes memset redundant. Build successfully. Signed-off-by: Himanshu Jha --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 --