Re: [PATCH] staging: sm750fb: Convert camel case to snake case

On Tue, Apr 06, 2021 at 11:36:41AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote: > > - struct dvi_ctrl_device *pCurrentDviCtrl; > > + struct dvi_ctrl_device *p_current_dvi_ctrl; > > Does this change make sense? Why keep the "p_" here? We do not need

Re: [PATCH] staging: sm750fb: Convert camel case to snake case

On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote: > - struct dvi_ctrl_device *pCurrentDviCtrl; > + struct dvi_ctrl_device *p_current_dvi_ctrl; Does this change make sense? Why keep the "p_" here? We do not need or use, this type of variable naming in the kernel. Also,

[PATCH] staging: sm750fb: Convert camel case to snake case

Fix "Avoid CamelCase" checkpatch.pl checks for 106 camel case instances: Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c| 32 ++--- drivers/staging/sm750fb/ddk750_dvi.h| 64 +- drivers/staging/sm750fb/ddk750_mode.c | 88 +++---